Bug in R&R has broken 2.0

Hey Danni,

I have found a bug in the 2.0 branch made by commit 365f36d (on Nov 4) that breaks the R&R process. It appears that the SQL in the getRnrLineItemsByRnrId method in the RnrLineItemMapper code has been modified to include a join to program_products. However, the SQL does not filter by program, so duplicate rows are being returned, which breaks the R&R submission process. Can you or your team take a look at this ASAP? We would like to resolve it quickly, so if we cannot fix it soon, it might have to be reversed.

Shalom,

Chongsun

– ​

There are 10 kinds of people in this world; those who understand binary, and those who don’t.

Chongsun Ahn | chongsun.ahn@villagereach.org

Software Development Engineer

Village****Reach* ** Starting at the Last Mile*

2900 Eastlake Ave. E, Suite 230, Seattle, WA 98102, USA

DIRECT: 1.206.512.1536 **CELL: **1.206.910.0973 FAX: 1.206.860.6972

SKYPE: chongsun.ahn.vr

www.villagereach.org

Connect on Facebook****, Twitter** ** and our Blog

Hi Chongsun,

Yes this has been mentioned by Elias - in our case we only have one program for each product, but the change unfortunately breaks products with multiple programs which we failed to check. I think Elias has fixed it but the merge probably didn’t make in to 2.0 branch. I’ll push a fix to 2.0. Thanks!

-Danni

···

On Fri, Jan 8, 2016 at 8:06 AM, Chongsun Ahn chongsun.ahn@villagereach.org wrote:

Hey Danni,

I have found a bug in the 2.0 branch made by commit 365f36d (on Nov 4) that breaks the R&R process. It appears that the SQL in the getRnrLineItemsByRnrId method in the RnrLineItemMapper code has been modified to include a join to program_products. However, the SQL does not filter by program, so duplicate rows are being returned, which breaks the R&R submission process. Can you or your team take a look at this ASAP? We would like to resolve it quickly, so if we cannot fix it soon, it might have to be reversed.

Shalom,

Chongsun

– ​

There are 10 kinds of people in this world; those who understand binary, and those who don’t.

Chongsun Ahn | chongsun.ahn@villagereach.org

Software Development Engineer

Village****Reach* ** Starting at the Last Mile*

2900 Eastlake Ave. E, Suite 230, Seattle, WA 98102, USA

DIRECT: 1.206.512.1536 **CELL: **1.206.910.0973 FAX: 1.206.860.6972

SKYPE: chongsun.ahn.vr

www.villagereach.org

Connect on Facebook****, Twitter** ** and our Blog

You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.

To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.

To post to this group, send email to openlmis-dev@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/9776721D-E4B1-4A3C-943D-A00203F6C5CD%40villagereach.org.

For more options, visit https://groups.google.com/d/optout.

Much appreciated Danni!

Cheers,

···

Kevin Cussen | kevin.cussen@villagereach.org

Manager, Information Systems

Village****Reach Starting at the Last Mile

2900 Eastlake Ave. E, Suite 230, Seattle, WA 98102, USA

CELL: 1.206.604.4209 FAX: 1.206.860.6972

SKYPE: kevin.cussen.vr

www.villagereach.org

Connect on Facebook,
Twitter and our Blog


From: openlmis-dev@googlegroups.com openlmis-dev@googlegroups.com on behalf of Danni Yu dyu@thoughtworks.com

Sent: Thursday, January 7, 2016 18:02

To: Chongsun Ahn

Cc: OpenLMIS Dev

Subject: Re: [openlmis-dev] Bug in R&R has broken 2.0

Hi Chongsun,

Yes this has been mentioned by Elias - in our case we only have one program for each product, but the change unfortunately breaks products with multiple programs which we failed to check. I think Elias has fixed it but the merge probably didn’t make in to 2.0 branch. I’ll push a fix to 2.0. Thanks!

-Danni

On Fri, Jan 8, 2016 at 8:06 AM, Chongsun Ahn
chongsun.ahn@villagereach.org wrote:

Hey Danni,

I have found a bug in the 2.0 branch made by commit 365f36d (on Nov 4) that breaks the R&R process. It appears that the SQL in the getRnrLineItemsByRnrId method in the RnrLineItemMapper code has been modified to include a join to program_products. However, the SQL does not filter by program, so duplicate rows are being returned, which breaks the R&R submission process. Can you or your team take a look at this ASAP? We would like to resolve it quickly, so if we cannot fix it soon, it might have to be reversed.

Shalom,

Chongsun

There are 10 kinds of people in this world; those who understand binary, and those who don’t.

Chongsun Ahn | chongsun.ahn@villagereach.org

Software Development Engineer

Village****Reach* ** Starting at the Last Mile*

2900 Eastlake Ave. E, Suite 230, Seattle, WA 98102, USA

DIRECT: 1.206.512.1536 **CELL: **1.206.910.0973
FAX: 1.206.860.6972

SKYPE: chongsun.ahn.vr

www.villagereach.org

Connect on Facebook****, Twitter** ** and our Blog

You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.

To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.

To post to this group, send email to
openlmis-dev@googlegroups.com.

To view this discussion on the web visit
https://groups.google.com/d/msgid/openlmis-dev/9776721D-E4B1-4A3C-943D-A00203F6C5CD%40villagereach.org
.

For more options, visit
https://groups.google.com/d/optout
.

You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.

To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.

To post to this group, send email to
openlmis-dev@googlegroups.com.

To view this discussion on the web visit
https://groups.google.com/d/msgid/openlmis-dev/CAMdhj_D7_JPPdMhs3vrPv-P5cHRdPhubp6w_baZsyaSiuisw_w%40mail.gmail.com
.

For more options, visit https://groups.google.com/d/optout.

Hi Chongsun,

I updated 2.0. When you get a chance, please check and confirm it is okay. Thanks :slight_smile:

-Danni

···

On Fri, Jan 8, 2016 at 10:31 AM, Kevin Cussen kevin.cussen@villagereach.org wrote:

Much appreciated Danni!

Cheers,

Kevin Cussen | kevin.cussen@villagereach.org

Manager, Information Systems

Village****Reach Starting at the Last Mile

2900 Eastlake Ave. E, Suite 230, Seattle, WA 98102, USA

CELL: 1.206.604.4209 FAX: 1.206.860.6972

SKYPE: kevin.cussen.vr

www.villagereach.org

Connect on Facebook,
Twitter and our Blog


From: openlmis-dev@googlegroups.com openlmis-dev@googlegroups.com on behalf of Danni Yu dyu@thoughtworks.com

Sent: Thursday, January 7, 2016 18:02

To: Chongsun Ahn

Cc: OpenLMIS Dev

Subject: Re: [openlmis-dev] Bug in R&R has broken 2.0

Hi Chongsun,

Yes this has been mentioned by Elias - in our case we only have one program for each product, but the change unfortunately breaks products with multiple programs which we failed to check. I think Elias has fixed it but the merge probably didn’t make in to 2.0 branch. I’ll push a fix to 2.0. Thanks!

-Danni

You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.

To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.

To post to this group, send email to
openlmis-dev@googlegroups.com.

To view this discussion on the web visit
https://groups.google.com/d/msgid/openlmis-dev/CAMdhj_D7_JPPdMhs3vrPv-P5cHRdPhubp6w_baZsyaSiuisw_w%40mail.gmail.com
.

For more options, visit https://groups.google.com/d/optout.

You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.

To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.

To post to this group, send email to openlmis-dev@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/CY1PR02MB1119A6702FD9953EAF30A33BE3F60%40CY1PR02MB1119.namprd02.prod.outlook.com.

For more options, visit https://groups.google.com/d/optout.

On Fri, Jan 8, 2016 at 8:06 AM, Chongsun Ahn
chongsun.ahn@villagereach.org wrote:

Hey Danni,

I have found a bug in the 2.0 branch made by commit 365f36d (on Nov 4) that breaks the R&R process. It appears that the SQL in the getRnrLineItemsByRnrId method in the RnrLineItemMapper code has been modified to include a join to program_products. However, the SQL does not filter by program, so duplicate rows are being returned, which breaks the R&R submission process. Can you or your team take a look at this ASAP? We would like to resolve it quickly, so if we cannot fix it soon, it might have to be reversed.

Shalom,

Chongsun

There are 10 kinds of people in this world; those who understand binary, and those who don’t.

Chongsun Ahn | chongsun.ahn@villagereach.org

Software Development Engineer

Village****Reach* ** Starting at the Last Mile*

2900 Eastlake Ave. E, Suite 230, Seattle, WA 98102, USA

DIRECT: 1.206.512.1536 **CELL: **1.206.910.0973
FAX: 1.206.860.6972

SKYPE: chongsun.ahn.vr

www.villagereach.org

Connect on Facebook****, Twitter** ** and our Blog

You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.

To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.

To post to this group, send email to
openlmis-dev@googlegroups.com.

To view this discussion on the web visit
https://groups.google.com/d/msgid/openlmis-dev/9776721D-E4B1-4A3C-943D-A00203F6C5CD%40villagereach.org
.

For more options, visit
https://groups.google.com/d/optout
.

Hey Danni,

It looks like the R&R is working again in 2.0. Many thanks for the quick turnaround.

Shalom,

Chongsun

– ​

There are 10 kinds of people in this world; those who understand binary, and those who don’t.

Chongsun Ahn | chongsun.ahn@villagereach.org

Software Development Engineer

Village****Reach* ** Starting at the Last Mile*

2900 Eastlake Ave. E, Suite 230, Seattle, WA 98102, USA

DIRECT: 1.206.512.1536 **CELL: **1.206.910.0973 FAX: 1.206.860.6972

SKYPE: chongsun.ahn.vr

www.villagereach.org

Connect on Facebook****, Twitter** ** and our Blog

···

On Fri, Jan 8, 2016 at 10:31 AM, Kevin Cussen
kevin.cussen@villagereach.org wrote:

Much appreciated Danni!

Cheers,

Kevin Cussen | kevin.cussen@villagereach.org

Manager, Information Systems

Village****Reach Starting at the Last Mile

2900 Eastlake Ave. E, Suite 230, Seattle, WA 98102, USA

CELL:
1.206.604.4209 FAX:
1.206.860.6972

SKYPE: kevin.cussen.vr

www.villagereach.org

Connect on Facebook,
Twitter and our Blog


From:
openlmis-dev@googlegroups.com openlmis-dev@googlegroups.com on behalf of Danni Yu dyu@thoughtworks.com

Sent: Thursday, January 7, 2016 18:02

To: Chongsun Ahn

Cc: OpenLMIS Dev

Subject: Re: [openlmis-dev] Bug in R&R has broken 2.0

Hi Chongsun,

Yes this has been mentioned by Elias - in our case we only have one program for each product, but the change unfortunately breaks products with multiple programs which we failed to check. I think Elias has fixed it but the merge probably didn’t make in to 2.0 branch. I’ll push a fix to 2.0. Thanks!

-Danni

You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.

To unsubscribe from this group and stop receiving emails from it, send an email to
openlmis-dev+unsubscribe@googlegroups.com.

To post to this group, send email to
openlmis-dev@googlegroups.com.

To view this discussion on the web visit
https://groups.google.com/d/msgid/openlmis-dev/CAMdhj_D7_JPPdMhs3vrPv-P5cHRdPhubp6w_baZsyaSiuisw_w%40mail.gmail.com
.

For more options, visit
https://groups.google.com/d/optout
.

You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.

To unsubscribe from this group and stop receiving emails from it, send an email to
openlmis-dev+unsubscribe@googlegroups.com.

To post to this group, send email to
openlmis-dev@googlegroups.com.

To view this discussion on the web visit
https://groups.google.com/d/msgid/openlmis-dev/CY1PR02MB1119A6702FD9953EAF30A33BE3F60%40CY1PR02MB1119.namprd02.prod.outlook.com
.

For more options, visit
https://groups.google.com/d/optout
.

On Fri, Jan 8, 2016 at 8:06 AM, Chongsun Ahn
chongsun.ahn@villagereach.org wrote:

Hey Danni,

I have found a bug in the 2.0 branch made by commit 365f36d (on Nov 4) that breaks the R&R process. It appears that the SQL in the getRnrLineItemsByRnrId method in the RnrLineItemMapper code has been modified to include a join to program_products. However, the SQL does not filter by program, so duplicate rows are being returned, which breaks the R&R submission process. Can you or your team take a look at this ASAP? We would like to resolve it quickly, so if we cannot fix it soon, it might have to be reversed.

Shalom,

Chongsun

There are 10 kinds of people in this world; those who understand binary, and those who don’t.

Chongsun Ahn | chongsun.ahn@villagereach.org

Software Development Engineer

Village****Reach* ** Starting at the Last Mile*

2900 Eastlake Ave. E, Suite 230, Seattle, WA 98102, USA

DIRECT: 1.206.512.1536 **CELL: **1.206.910.0973
FAX: 1.206.860.6972

SKYPE: chongsun.ahn.vr

www.villagereach.org

Connect on Facebook****, Twitter** ** and our Blog

You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.

To unsubscribe from this group and stop receiving emails from it, send an email to
openlmis-dev+unsubscribe@googlegroups.com.

To post to this group, send email to
openlmis-dev@googlegroups.com.

To view this discussion on the web visit
https://groups.google.com/d/msgid/openlmis-dev/9776721D-E4B1-4A3C-943D-A00203F6C5CD%40villagereach.org
.

For more options, visit
https://groups.google.com/d/optout
.