New export logic in openlmis

Hi,

We have a story for export (to Excel) for openlmis. We added some util logic using POI to generate Excel based on templates. The question is where we should be putting such logic.

Two ways we discussed are:

  1. rename “upload” module to “file-management” and that module will include both import and export logic of files

  2. add a new module “export”

Wondering if the community has any thoughts about this… Currently we have decided to go with option #1 because we see “file-management” module could include file util operations going forward. But we are open to change it.

Also, we’re aware that renaming the “upload” module may result in conflicts and hence have not yet merged that code to 2.0 until we hear further from your thoughts.

Thanks!

-Danni & Jie

Is the logic (or, format of Excel) general or specific to Mozambique?

Maybe build an extension point (i.e. an interface + default implementation) in OpenLMIS, and extend from Moz implementation?

···

On 10 November 2015 at 11:52, Danni Yu dyu@thoughtworks.com wrote:

Hi,

We have a story for export (to Excel) for openlmis. We added some util logic using POI to generate Excel based on templates. The question is where we should be putting such logic.

Two ways we discussed are:

  1. rename “upload” module to “file-management” and that module will include both import and export logic of files
  1. add a new module “export”

Wondering if the community has any thoughts about this… Currently we have decided to go with option #1 because we see “file-management” module could include file util operations going forward. But we are open to change it.

Also, we’re aware that renaming the “upload” module may result in conflicts and hence have not yet merged that code to 2.0 until we hear further from your thoughts.

Thanks!

-Danni & Jie

You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.

To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.

To post to this group, send email to openlmis-dev@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/CAMdhj_BwNzEQ3zow7TzAhE7M0DMVjBZvhzWs1HQ9S%2BPdz_f1jg%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.

Jeff Xiong
ThoughtWorks
+86 186 826 53819

Hi Danni and Jie,

Thanks for sharing this design decision with the community. Based on my limited understanding from your description, you are trying to decide the best approach between:

  1. Modifying the existing upload “module” to also include exports

  2. Creating a separate “Export” module

My gut reaction would be to instead go with #2 for the following reasons:

  1. Unless imports & exports are linked in a flow (or you are planning on adding further file-management activities), I don’t think they should be part of the same module.

  2. Legacy compatibility

Please inform whether this makes sense. I’m also interested in what other functionality you envision in the file-management module.

Cheers,

···

Kevin Cussen

Technology Manager

Village****Reach* ** Starting at the Last Mile*

2900 Eastlake Ave. E, Suite 230, Seattle, WA 98102, USA

CELL: 1.206.604.4209

www.villagereach.org

Connect on Facebook, Twitter** ** and our Blog


From: openlmis-dev@googlegroups.com openlmis-dev@googlegroups.com on behalf of Jie Xiong jxiong@thoughtworks.com

Sent: Tuesday, November 10, 2015 00:21

To: Danni Yu

Cc: OpenLMIS Dev; chai-openlmis

Subject: Re: [openlmis-dev] New export logic in openlmis

Is the logic (or, format of Excel) general or specific to Mozambique?

Maybe build an extension point (i.e. an interface + default implementation) in OpenLMIS, and extend from Moz implementation?

On 10 November 2015 at 11:52, Danni Yu dyu@thoughtworks.com wrote:

Hi,

We have a story for export (to Excel) for openlmis. We added some util logic using POI to generate Excel based on templates. The question is where we should be putting such logic.

Two ways we discussed are:

  1. rename “upload” module to “file-management” and that module will include both import and export logic of files
  1. add a new module “export”

Wondering if the community has any thoughts about this… Currently we have decided to go with option #1 because we see “file-management” module could include file util operations going forward. But we are open to change it.

Also, we’re aware that renaming the “upload” module may result in conflicts and hence have not yet merged that code to 2.0 until we hear further from your thoughts.

Thanks!

-Danni & Jie

You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.

To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.

To post to this group, send email to
openlmis-dev@googlegroups.com.

To view this discussion on the web visit
https://groups.google.com/d/msgid/openlmis-dev/CAMdhj_BwNzEQ3zow7TzAhE7M0DMVjBZvhzWs1HQ9S%2BPdz_f1jg%40mail.gmail.com
.

For more options, visit
https://groups.google.com/d/optout
.


Jeff Xiong

ThoughtWorks

+86 186 826 53819

You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.

To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.

To post to this group, send email to
openlmis-dev@googlegroups.com.

To view this discussion on the web visit
https://groups.google.com/d/msgid/openlmis-dev/CANMPmeQPSJEjRL7Xb%3D7L9feUUMMQz_5PANBdGt8QoWrK%2B39W6A%40mail.gmail.com
.

For more options, visit https://groups.google.com/d/optout.

Hello Kevin and Jeff,

Thanks for you opinion.

When we talked about the upload functionality, it has two parts actually. The real upload module which only handling the CVS files, the logic are all in the core module.

On the other hand, the export will only handling the Excel files. The logic are distributed at the specific Service, like the data populating

So this is the key point of refactor it to a file management module. It will only contain general files handling related functionalities.

We have email template files, Requisition report template files now.

Best Regards!

Jie Liu(刘杰) Developer

ThoughtWorks Wuhan, China.

Email: jjliu@thoughtworks.com

Mobile:+86 18628038506

···

Kevin Cussen

Technology Manager

Village****Reach* ** Starting at the Last Mile*

2900 Eastlake Ave. E, Suite 230, Seattle, WA 98102, USA

CELL: 1.206.604.4209

www.villagereach.org

Connect on Facebook, Twitter** ** and our Blog


From: openlmis-dev@googlegroups.com openlmis-dev@googlegroups.com on behalf of Jie Xiong jxiong@thoughtworks.com

Sent: Tuesday, November 10, 2015 00:21

To: Danni Yu

Cc: OpenLMIS Dev; chai-openlmis

Subject: Re: [openlmis-dev] New export logic in openlmis

Is the logic (or, format of Excel) general or specific to Mozambique?

Maybe build an extension point (i.e. an interface + default implementation) in OpenLMIS, and extend from Moz implementation?

On 10 November 2015 at 11:52, Danni Yu dyu@thoughtworks.com wrote:

Hi,

We have a story for export (to Excel) for openlmis. We added some util logic using POI to generate Excel based on templates. The question is where we should be putting such logic.

Two ways we discussed are:

  1. rename “upload” module to “file-management” and that module will include both import and export logic of files
  1. add a new module “export”

Wondering if the community has any thoughts about this… Currently we have decided to go with option #1 because we see “file-management” module could include file util operations going forward. But we are open to change it.

Also, we’re aware that renaming the “upload” module may result in conflicts and hence have not yet merged that code to 2.0 until we hear further from your thoughts.

Thanks!

-Danni & Jie

You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.

To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.

To post to this group, send email to
openlmis-dev@googlegroups.com.

To view this discussion on the web visit
https://groups.google.com/d/msgid/openlmis-dev/CAMdhj_BwNzEQ3zow7TzAhE7M0DMVjBZvhzWs1HQ9S%2BPdz_f1jg%40mail.gmail.com
.

For more options, visit
https://groups.google.com/d/optout
.


Jeff Xiong

ThoughtWorks

+86 186 826 53819

You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.

To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.

To post to this group, send email to
openlmis-dev@googlegroups.com.

To view this discussion on the web visit
https://groups.google.com/d/msgid/openlmis-dev/CANMPmeQPSJEjRL7Xb%3D7L9feUUMMQz_5PANBdGt8QoWrK%2B39W6A%40mail.gmail.com
.

For more options, visit https://groups.google.com/d/optout.