Orderable dispensable field

Hi all,

We found out that the dispensable field in Orderable DTO is represented as a separate object. Currently this object contains only one field: dispensingUnit. Will this object be extend in the future? Should we flatten it in the DTO?

Regards,

Lukasz


SolDevelo
Sp. z o.o. [LLC] / www.soldevelo.com
Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland
Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41

···

Łukasz Lewczyński
Software Developer
llewczynski@soldevelo.com

Hi Łukasz,

You can read about Dispensable design here: https://openlmis.atlassian.net/wiki/spaces/OP/pages/91848875/Design+of+Dispensible.

As Dispensable is Value Object, we probably can flatten it in DTO but what would that give us?

Regards,

Paweł

···

On Monday, December 4, 2017 at 3:43:19 PM UTC+1, Łukasz Lewczyński wrote:

Hi all,

We found out that the dispensable field in Orderable DTO is represented as a separate object. Currently this object contains only one field: dispensingUnit. Will this object be extend in the future? Should we flatten it in the DTO?

Regards,

Lukasz

Łukasz Lewczyński
Software Developer
llewc...@soldevelo.com


SolDevelo
Sp. z o.o. [LLC] / www.soldevelo.com
Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland
Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41

I asked about that because on UI we have: orderable.dispensable.dispensingUnit and could be orderable.dispensingUnit but according to the wiki page it seems that this value object will contain additional fields (like Form or Dosage Unit) so we probably should not flatten it in DTO.


SolDevelo
Sp. z o.o. [LLC] / www.soldevelo.com
Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland
Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41

···

On Mon, Dec 4, 2017 at 4:25 PM, Paweł Albecki palbecki@soldevelo.com wrote:

Hi Łukasz,

You can read about Dispensable design here: https://openlmis.atlassian.net/wiki/spaces/OP/pages/91848875/Design+of+Dispensible.

As Dispensable is Value Object, we probably can flatten it in DTO but what would that give us?

Regards,

Paweł

On Monday, December 4, 2017 at 3:43:19 PM UTC+1, Łukasz Lewczyński wrote:

Hi all,

We found out that the dispensable field in Orderable DTO is represented as a separate object. Currently this object contains only one field: dispensingUnit. Will this object be extend in the future? Should we flatten it in the DTO?

Regards,

Lukasz

Łukasz Lewczyński
Software Developer
llewc...@soldevelo.com

**
SolDevelo** Sp. z o.o. [LLC] / www.soldevelo.com
Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland
Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41

**
SolDevelo** Sp. z o.o. [LLC] / www.soldevelo.com
Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland
Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41

You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.

To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.

To post to this group, send email to openlmis-dev@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/0f84b012-ebca-4b27-bd95-b3785fcd228e%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

Łukasz Lewczyński
Software Developer
llewczynski@soldevelo.com