During the QA on OLMIS-3956 Joana suggests that I should change POD endpoints name from proofOfDeliveries to proofsOfDelivery because “Proof of Delivery” is the correct form - it’s a proof of one delivery, not of multiple ones.
The question is should we change endpoints name? If we decide to change it, we should stay consistent with everything else like model, db schema, etc. Also this change breaks our naming conventions for rest resources.
For now I will stay with current name to avoid the renaming multiple times.
Our style guide says: Resource names should be pluralized and consistent. Neither proofOfDeliveries nor proofOfDelivery are in plural form so I would vote for change database column and resource name to proofsOfDelivery.
During the QA on OLMIS-3956 Joana suggests that I should change POD endpoints name from proofOfDeliveries to proofsOfDelivery because “Proof of Delivery” is the correct form - it’s a proof of one delivery, not of multiple ones.
The question is should we change endpoints name? If we decide to change it, we should stay consistent with everything else like model, db schema, etc. Also this change breaks our naming conventions for rest resources.
For now I will stay with current name to avoid the renaming multiple times.
I agree with Paweł; the plural form of proof of delivery is proofs of delivery. The main noun is proof, so it is pluralized. Proof of deliveries would be a single proof of multiple deliveries.
During the QA on
OLMIS-3956 Joana suggests that I should change POD endpoints name from proofOfDeliveries to proofsOfDelivery because “Proof of Delivery” is the correct form - it’s a proof of one delivery, not of multiple ones.
The question is should we change endpoints name? If we decide to change it, we should stay consistent with everything else like model, db schema, etc. Also this change breaks our naming conventions for rest resources.
For now I will stay with current name to avoid the renaming multiple times.
I guess the question is whether we should go ahead and modify all of our endpoints and database table names to match this. I think the external dependencies for those endpoints and tables are minimal for now, so there shouldn’t be too much of a problem with this.
···
On 08.02.2018 18:04, Chongsun Ahn wrote:
I agree with Paweł; the plural form of proof of delivery is proofs of delivery. The main noun is proof, so it is pluralized. Proof of deliveries would be a single proof of multiple deliveries.
I found this for proof of concept, which is similar: [https://en.wiktionary.org/wiki/proof_of_concept](https://en.wiktionary.org/wiki/proof_of_concept)
Shalom,
Chongsun
--
There are 10 kinds of people in this world; those who understand binary, and those who don’t.
Our style guide says: * Resource names should be pluralized and consistent.* Neither proofOfDeliveries nor proofOfDelivery
are in plural form so I would vote for change database column and resource name to proofsOfDelivery.
Regards,
Paweł
On Thu, Feb 8, 2018 at 12:47 PM, Łukasz Lewczyński
<llewczynski@soldevelo.com>
wrote:
Hi,
During the QA on
OLMIS-3956 Joana suggests that I should change POD endpoints name from proofOfDeliveries
to proofsOfDelivery because “Proof of Delivery” is the correct form - it’s a proof of one delivery, not of multiple ones.
The question is should we change endpoints name? If we decide to change it, we should stay consistent with everything else like model, db schema, etc. Also this change breaks our naming conventions for rest resources.
For now I will stay with current name to avoid the renaming multiple times.
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to
openlmis-dev+unsubscribe@googlegroups.com.
To post to this group, send email to
openlmis-dev@googlegroups.com.
To view this discussion on the web visit [
https://groups.google.com/d/msgid/openlmis-dev/CAAdp53zaoxEsBhRXSWi7mZuCwPVgi47%3DmW-VvMnnVg3ccxc-xg%40mail.gmail.com](https://groups.google.com/d/msgid/openlmis-dev/CAAdp53zaoxEsBhRXSWi7mZuCwPVgi47%3DmW-VvMnnVg3ccxc-xg%40mail.gmail.com?utm_medium=email&utm_source=footer).
For more options, visit [
https://groups.google.com/d/optout](https://groups.google.com/d/optout).
–
Paweł Albecki
Software Developer
palbecki@soldevelo.com
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.
To post to this group, send email to
openlmis-dev@googlegroups.com.
To view this discussion on the web visit [
For more options, visit [https://groups.google.com/d/optout](https://groups.google.com/d/optout).
–
You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.
To post to this group, send email to openlmis-dev@googlegroups.com.
To view this discussion on the web visit [https://groups.google.com/d/msgid/openlmis-dev/245AEB7C-69CF-4074-B153-C2767389F3C8%40villagereach.org](https://groups.google.com/d/msgid/openlmis-dev/245AEB7C-69CF-4074-B153-C2767389F3C8%40villagereach.org?utm_medium=email&utm_source=footer).
For more options, visit [https://groups.google.com/d/optout](https://groups.google.com/d/optout).
+1 for changing the names now. Now is the easiest time to change it—while everything is still under construction. The cost and pain of changing later will be higher.
I guess the question is whether we should go ahead and modify all of our endpoints and database table names to match this. I think the external dependencies for those endpoints and tables are minimal for now, so there shouldn’t be too much of a problem with this.
+1 for changing the names now. Now is the easiest time to change it—while everything is still under construction. The cost and pain of changing later will be higher.
I guess the question is whether we should go ahead and modify all of our endpoints and database table names to match this. I think the external dependencies for those endpoints and tables are minimal for now, so there shouldn’t be too much of a problem with this.
–
You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.
