POD endpoints name

Hi,

During the QA on OLMIS-3956 Joana suggests that I should change POD endpoints name from proofOfDeliveries to proofsOfDelivery because “Proof of Delivery” is the correct form - it’s a proof of one delivery, not of multiple ones.

The question is should we change endpoints name? If we decide to change it, we should stay consistent with everything else like model, db schema, etc. Also this change breaks our naming conventions for rest resources.

For now I will stay with current name to avoid the renaming multiple times.

Regards,

Lukasz


SolDevelo
Sp. z o.o. [LLC] / www.soldevelo.com
Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland
Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41

···

Łukasz Lewczyński
Software Developer
llewczynski@soldevelo.com

Our style guide says: Resource names should be pluralized and consistent. Neither proofOfDeliveries nor proofOfDelivery are in plural form so I would vote for change database column and resource name to proofsOfDelivery.

Regards,

Paweł


SolDevelo
Sp. z o.o. [LLC] / www.soldevelo.com
Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland
Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41

···

On Thu, Feb 8, 2018 at 12:47 PM, Łukasz Lewczyński llewczynski@soldevelo.com wrote:

Hi,

During the QA on OLMIS-3956 Joana suggests that I should change POD endpoints name from proofOfDeliveries to proofsOfDelivery because “Proof of Delivery” is the correct form - it’s a proof of one delivery, not of multiple ones.

The question is should we change endpoints name? If we decide to change it, we should stay consistent with everything else like model, db schema, etc. Also this change breaks our naming conventions for rest resources.

For now I will stay with current name to avoid the renaming multiple times.

Regards,

Lukasz

Łukasz Lewczyński
Software Developer
llewczynski@soldevelo.com


SolDevelo
Sp. z o.o. [LLC] / www.soldevelo.com
Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland
Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41

You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.

To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.

To post to this group, send email to openlmis-dev@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/CAAdp53zaoxEsBhRXSWi7mZuCwPVgi47%3DmW-VvMnnVg3ccxc-xg%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.

Paweł Albecki

    Software Developer

     palbecki@soldevelo.com

I agree with Paweł; the plural form of proof of delivery is proofs of delivery. The main noun is proof, so it is pluralized. Proof of deliveries would be a single proof of multiple deliveries.

I found this for proof of concept, which is similar: https://en.wiktionary.org/wiki/proof_of_concept

Shalom,

Chongsun

– ​

There are 10 kinds of people in this world; those who understand binary, and those who don’t.

Chongsun Ahn | chongsun.ahn@villagereach.org

Software Development Engineer

Village****Reach* ** Starting at the Last Mile*

2900 Eastlake Ave. E, Suite 230, Seattle, WA 98102, USA

DIRECT: 1.206.512.1536 **CELL: **1.206.910.0973 FAX: 1.206.860.6972

SKYPE: chongsun.ahn.vr

www.villagereach.org

Connect on Facebook****, Twitter** ** and our Blog

···

On Thu, Feb 8, 2018 at 12:47 PM, Łukasz Lewczyński
llewczynski@soldevelo.com wrote:

Hi,

During the QA on
OLMIS-3956
Joana suggests that I should change POD endpoints name from proofOfDeliveries to proofsOfDelivery because “Proof of Delivery” is the correct form - it’s a proof of one delivery, not of multiple ones.

The question is should we change endpoints name? If we decide to change it, we should stay consistent with everything else like model, db schema, etc. Also this change breaks our naming conventions for rest resources.

For now I will stay with current name to avoid the renaming multiple times.

Regards,

Lukasz

Łukasz Lewczyński

Software Developer

llewczynski@soldevelo.com

**

SolDevelo** Sp. z o.o. [LLC] /
www.soldevelo.com

Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland

Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41

You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.

To unsubscribe from this group and stop receiving emails from it, send an email to
openlmis-dev+unsubscribe@googlegroups.com.

To post to this group, send email to
openlmis-dev@googlegroups.com.

To view this discussion on the web visit
https://groups.google.com/d/msgid/openlmis-dev/CAAdp53zaoxEsBhRXSWi7mZuCwPVgi47%3DmW-VvMnnVg3ccxc-xg%40mail.gmail.com
.

For more options, visit
https://groups.google.com/d/optout
.

Paweł Albecki

Software Developer

palbecki@soldevelo.com

I guess the question is whether we should go ahead and modify all of our endpoints and database table names to match this. I think the external dependencies for those endpoints and tables are minimal for now, so there shouldn’t be too much of a problem with this.

···

On 08.02.2018 18:04, Chongsun Ahn wrote:

  I agree with Paweł; the plural form of proof of delivery is proofs of delivery. The main noun is proof, so it is pluralized. Proof of deliveries would be a single proof of multiple deliveries.
    I found this for proof of concept, which is similar: [https://en.wiktionary.org/wiki/proof_of_concept](https://en.wiktionary.org/wiki/proof_of_concept)


                Shalom,

                Chongsun

                ​

                -- ​

                There are 10 kinds of people in this world; those who understand binary, and those who don’t.

Chongsun Ahn | chongsun.ahn@villagereach.org

  •                      Software Development Engineer*
    

Village****Reach* ** Starting at the Last Mile*

                    2900 Eastlake Ave. E, Suite 230,  Seattle, WA 98102, USA

DIRECT: 1.206.512.1536 **CELL: ** 1.206.910.0973 FAX: 1.206.860.6972

SKYPE: chongsun.ahn.vr

www.villagereach.org

Connect on Facebook****, Twitter** **and our Blog

On Feb 8, 2018, at 6:15 AM, Paweł Albecki <palbecki@soldevelo.com > wrote:

Our style guide says: * Resource names should be pluralized and consistent.* Neither proofOfDeliveries nor proofOfDelivery
are in plural form so I would vote for change database column and resource name to proofsOfDelivery.

Regards,

Paweł

              On Thu, Feb 8, 2018 at 12:47 PM, Łukasz Lewczyński
                <llewczynski@soldevelo.com>
              wrote:

Hi,

During the QA on
OLMIS-3956
Joana suggests that I should change POD endpoints name from proofOfDeliveries
to proofsOfDelivery because “Proof of Delivery” is the correct form - it’s a proof of one delivery, not of multiple ones.

                    The question is should we change endpoints name? If we decide to change it, we should stay consistent with everything else like model, db schema, etc. Also this change breaks our naming conventions for rest resources.
                    For now I will stay with current name to avoid the renaming multiple times.

Regards,

Lukasz

** Łukasz Lewczyński**

                              Software Developer

                              llewczynski@soldevelo.com
                **![](http://www.soldevelo.com/sites/default/files/Soldevelo_logo_EPS_CMYK.png)

                    SolDevelo** Sp. z o.o. [LLC] / [
                    www.soldevelo.com](http://www.soldevelo.com/)

                  [Al. Zwycięstwa 96](https://maps.google.com/?q=Al.+Zwyci%C4%99stwa+96&entry=gmail&source=g)                      /98, 81-451, Gdynia, Poland

                  Phone:                         +48 58 782 45 40 / Fax: +48 58 782 45 41

                    You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.

                    To unsubscribe from this group and stop receiving emails from it, send an email to
                      openlmis-dev+unsubscribe@googlegroups.com.

                    To post to this group, send email to
                      openlmis-dev@googlegroups.com.

                    To view this discussion on the web visit [
                      https://groups.google.com/d/msgid/openlmis-dev/CAAdp53zaoxEsBhRXSWi7mZuCwPVgi47%3DmW-VvMnnVg3ccxc-xg%40mail.gmail.com](https://groups.google.com/d/msgid/openlmis-dev/CAAdp53zaoxEsBhRXSWi7mZuCwPVgi47%3DmW-VvMnnVg3ccxc-xg%40mail.gmail.com?utm_medium=email&utm_source=footer).

                    For more options, visit [
                      https://groups.google.com/d/optout](https://groups.google.com/d/optout).

                              Paweł Albecki

                            Software Developer

                            palbecki@soldevelo.com
          **![](http://www.soldevelo.com/sites/default/files/Soldevelo_logo_EPS_CMYK.png)

              SolDevelo** Sp. z o.o. [LLC] / [
              www.soldevelo.com](http://www.soldevelo.com/)

            Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland

            Phone:                   +48 58 782 45 40 / Fax:                   +48 58 782 45 41

          You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.

          To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.

          To post to this group, send email to
            openlmis-dev@googlegroups.com.

          To view this discussion on the web visit [

https://groups.google.com/d/msgid/openlmis-dev/CAAJzpfnmcHV_JUpu8NXRHtP0sUO4S-h-4Zkqiqpru--Z8siZ1A%40mail.gmail.com](https://groups.google.com/d/msgid/openlmis-dev/CAAJzpfnmcHV_JUpu8NXRHtP0sUO4S-h-4Zkqiqpru--Z8siZ1A%40mail.gmail.com?utm_medium=email&utm_source=footer).

          For more options, visit [https://groups.google.com/d/optout](https://groups.google.com/d/optout).

  You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.

  To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.

  To post to this group, send email to openlmis-dev@googlegroups.com.

  To view this discussion on the web visit [https://groups.google.com/d/msgid/openlmis-dev/245AEB7C-69CF-4074-B153-C2767389F3C8%40villagereach.org](https://groups.google.com/d/msgid/openlmis-dev/245AEB7C-69CF-4074-B153-C2767389F3C8%40villagereach.org?utm_medium=email&utm_source=footer).

  For more options, visit [https://groups.google.com/d/optout](https://groups.google.com/d/optout).


Sebastian Brudziński

              Senior Software Developer / Team Leader


SolDevelo
Sp. z o.o. [LLC] / www.soldevelo.com
Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland
Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41
sbrudzinski@soldevelo.com

+1 for changing the names now. Now is the easiest time to change it—while everything is still under construction. The cost and pain of changing later will be higher.

-Brandon

···

From: openlmis-dev@googlegroups.com on behalf of Sebastian Brudziński sbrudzinski@soldevelo.com

I guess the question is whether we should go ahead and modify all of our endpoints and database table names to match this. I think the external dependencies for those endpoints and tables are minimal for now, so there shouldn’t be too much of a problem with this.

I created a ticket to rename POD resource: OLMIS-4119. I also added it to the Backlog Grooming Sprint 47.


SolDevelo
Sp. z o.o. [LLC] / www.soldevelo.com
Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland
Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41

···

On Fri, Feb 9, 2018 at 5:52 PM, Brandon Bowersox-Johnson brandon.bowersox-johnson@villagereach.org wrote:

+1 for changing the names now. Now is the easiest time to change it—while everything is still under construction. The cost and pain of changing later will be higher.

-Brandon

From: openlmis-dev@googlegroups.com on behalf of Sebastian Brudziński sbrudzinski@soldevelo.com

I guess the question is whether we should go ahead and modify all of our endpoints and database table names to match this. I think the external dependencies for those endpoints and tables are minimal for now, so there shouldn’t be too much of a problem with this.

You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.

To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.

To post to this group, send email to openlmis-dev@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/514A046D-6B58-4CD0-B23C-66D322642A51%40villagereach.org.

For more options, visit https://groups.google.com/d/optout.

Łukasz Lewczyński
Software Developer
llewczynski@soldevelo.com