Proposal to move stock management code from stock-management repo into OpenLMIS

Hey all,

I am proposing that we move the stock management code out of the separate stock-management repo back into OpenLMIS. Some reasons:

  • Having a separate repo and using git submodule creates additional complexity. There are two repos to manage.

  • Additionally, there is confusion about what commit the stock management submodule is pointing to. The stock management commit changes when the open-lmis branch/commit is changed.

  • When the stock-management module’s commit is updated, a separate commit needs to be made in the parent module in order to avoid confusion.

  • The original reason why we created it does not seem to be applicable anymore. (no access to VIMS bitbucket)

  • Continuous integration is difficult with subrepos.

  • Subrepos in general are not meant to solve this issue.

If there are other reasons, feel free to chime in.

We should discuss this in the weekly OpenLMIS technical community call tomorrow.

Shalom,

Chongsun

– ​

There are 10 kinds of people in this world; those who understand binary, and those who don’t.

Chongsun Ahn | chongsun.ahn@villagereach.org

Software Development Engineer

Village****Reach* ** Starting at the Last Mile*

2900 Eastlake Ave. E, Suite 230, Seattle, WA 98102, USA

DIRECT: 1.206.512.1536 **CELL: **1.206.910.0973 FAX: 1.206.860.6972

SKYPE: chongsun.ahn.vr

www.villagereach.org

Connect on Facebook****, Twitter** ** and our Blog

Hi all,

I’m all for this, I’ve recently received feedback to this effect from several parties. Great suggestion Chongsun.

Cheers,

···

Kevin Cussen

Technology Manager

Village****Reach* ** Starting at the Last Mile*

2900 Eastlake Ave. E, Suite 230, Seattle, WA 98102, USA

CELL: 1.206.604.4209

www.villagereach.org

Connect on Facebook, Twitter** ** and our Blog


From: openlmis-dev@googlegroups.com openlmis-dev@googlegroups.com on behalf of Chongsun Ahn chongsun.ahn@villagereach.org

Sent: Monday, December 7, 2015 12:46

To: OpenLMIS Dev

Subject: [openlmis-dev] Proposal to move stock management code from stock-management repo into OpenLMIS

Hey all,

I am proposing that we move the stock management code out of the separate stock-management repo back into OpenLMIS. Some reasons:

  • Having a separate repo and using git submodule creates additional complexity. There are two repos to manage.

  • Additionally, there is confusion about what commit the stock management submodule is pointing to. The stock management commit changes when the open-lmis branch/commit is changed.

  • When the stock-management module’s commit is updated, a separate commit needs to be made in the parent module in order to avoid confusion.

  • The original reason why we created it does not seem to be applicable anymore. (no access to VIMS bitbucket)

  • Continuous integration is difficult with subrepos.

  • Subrepos in general are not meant to solve this issue.

If there are other reasons, feel free to chime in.

We should discuss this in the weekly OpenLMIS technical community call tomorrow.

Shalom,

Chongsun

There are 10 kinds of people in this world; those who understand binary, and those who don’t.

Chongsun Ahn | chongsun.ahn@villagereach.org

Software Development Engineer

Village****Reach* ** Starting at the Last Mile*

2900 Eastlake Ave. E, Suite 230, Seattle, WA 98102, USA

DIRECT: 1.206.512.1536 **CELL: **1.206.910.0973 FAX: 1.206.860.6972

SKYPE: chongsun.ahn.vr

www.villagereach.org

Connect on Facebook****, Twitter** ** and our Blog

You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.

To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.

To post to this group, send email to
openlmis-dev@googlegroups.com.

To view this discussion on the web visit
https://groups.google.com/d/msgid/openlmis-dev/47A5D282-AED7-4B1A-817F-FB0674FA35A3%40villagereach.org
.

For more options, visit https://groups.google.com/d/optout.