One more thing, we still don’t have quality gate for duplications. Łukasz, will you add this or I should do it?
···
On Wed, Feb 21, 2018 at 11:50 AM, Paweł Gesek pgesek@soldevelo.com wrote:
If we have rules that we don’t intend to follow we should disable them, before we set the gates to fail.
The argument of sacrificing quality to achieve deadlines is a slippery slope - for example Scrum forbids it during a sprint. We all know how it goes when there is a rush towards a release, but all debt has to be paid sooner or later.
Regards,
Paweł

SolDevelo Sp. z o.o. [LLC] / www.soldevelo.com
Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland
Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41
–
You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.
To post to this group, send email to openlmis-dev@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/CADt-Nu1b3RKRhTAwiLDgVwPGVvbZNY%3D%3D51A__7tuPeD3iV3Mjg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
–
On Wed, Feb 21, 2018 at 11:29 AM, Paweł Albecki palbecki@soldevelo.com wrote:
Code smell is just tech debt. I am also for fixing them immediately as they arise but I am wondering if dealing with things like small code duplication, cyclomatic complexity or remove usage of some deprecated class is more important than deliver on time.
We also have some sonar rules that doesn’t make sense like: Annotate the interface with the @FunctionalInterface annotation. Not every interface with one method is suppose to be used as functional interface.

SolDevelo Sp. z o.o. [LLC] / www.soldevelo.com
Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland
Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41
–
Paweł Gesek
Technical Project Manager
pgesek@soldevelo.com / +48 690 020 875
On Wed, Feb 21, 2018 at 10:43 AM, Paweł Gesek pgesek@soldevelo.com wrote:
+1 to breaking the build on code smells - these warnings usually have little sense if they don’t break the builds.
Regards,
Paweł

SolDevelo Sp. z o.o. [LLC] / www.soldevelo.com
Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland
Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41
–
Paweł Albecki
Software Developer
palbecki@soldevelo.com
On Mon, Feb 19, 2018 at 2:16 PM, Mateusz Kwiatkowski mkwiatkowski@soldevelo.com wrote:
Hi Pawel,
I don’t think it is that bad, Sonar build does not block other whole workflow so changes will be deployed etc., than you can disable issue on Sonar and next Sonar build won’t fail, but you are right, some notification will suffice.
Regards,
Mateusz

SolDevelo Sp. z o.o. [LLC] / www.soldevelo.com
Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland
Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41
–
You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.
To post to this group, send email to openlmis-dev@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/CAHq-FDPR%3DDVwsk_Ve93%2BVCfsReR2GUwZhk78HTdXimp%3DA56yeQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
–
Paweł Gesek
Technical Project Manager
pgesek@soldevelo.com / +48 690 020 875
On Mon, Feb 19, 2018 at 1:50 PM, Paweł Albecki palbecki@soldevelo.com wrote:
Hi Mateusz,
I do not think it is the best idea to have sonar build failed just because there are some small code smells. It will be great, though, if you find a way to have some notifications for developers who introduced that smell and maybe to Slack #dev channel as well.
Best regards,
Paweł

SolDevelo Sp. z o.o. [LLC] / www.soldevelo.com
Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland
Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41
On Mon, Feb 19, 2018 at 1:08 PM, mkwiatkowski mkwiatkowski@soldevelo.com wrote:
Hi all,
I want to revive this discussion and ask simple question: is it a good idea to restrict our quality gate a bit? On our Learning Session we agreed that the gate should fail on any new code smell, if we won’t be fixing them we can always remove issue directly from the Sonar. Now when we are introducing code smells we don’t have any info if we don’t check Sonar manually.
Regards,
Mateusz
On Tuesday, November 28, 2017 at 1:18:30 PM UTC+1, Łukasz Lewczyński wrote:
Hi all,
The Sonar Quality Gate has been enabled for all core services. I had to create new Jenkins jobs (as pipeline) but I left old for now in case if I missed any configuration. I will probably remove them near the end of the sprint.
For now we use default settings for Quality Gate:
- Coverage on New Code >= 80%
- New Bugs == 0
- New Vulnerabilities == 0
- Technical Debt Ratio on New Code <= 5%
The information about Quality Gate status for each service will be displayed on #build slack channel. In the end when you commit new changes please ensure that Quality Gate pass.
Regards,
Lukasz
Łukasz Lewczyński
Software Developer
llewc...@soldevelo.com

SolDevelo Sp. z o.o. [LLC] / www.soldevelo.com
Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland
Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41

SolDevelo Sp. z o.o. [LLC] / www.soldevelo.com
Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland
Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41
–
You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.
To post to this group, send email to openlmis-dev@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/202a0dc7-17d5-473e-84f5-c01b379766b0%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
–
Paweł Albecki
Software Developer
palbecki@soldevelo.com
Paweł Albecki
Software Developer
palbecki@soldevelo.com