Hello. I have been working on ticket OLMIS-598 and I just wrote quick recommendations for developing unit tests. Could you suggest me, where upload this document? I’m also attaching the document and I will be grateful for your opinions.
Leszek Kukiełka
UT recommendations.pdf (29.6 KB)
These should go on the wiki. And rather than “recommendations”, it’s best to think of this as “setting conventions for the OpenLMIS dev community.”
I would advise creating a “Conventions” page either under https://openlmis.atlassian.net/wiki/display/OP/OpenLMIS+Coding+Standards or directly under the Developer Guide page.
Here’s an example from OpenMRS: https://wiki.openmrs.org/x/LwAJ I wouldn’t follow this exactly, but note the idea that there are conventions about quite a few different things.
Also, I would suggest that this goes a lot better with a code example, or even better, if each convention links to a real code example from our code on github, showing how things should be done.
-Darius
On Wed, Jun 8, 2016 at 10:36 AM, lkukielka@soldevelo.com lkukielka@soldevelo.com wrote:
Hello. I have been working on ticket OLMIS-598 and I just wrote quick recommendations for developing unit tests. Could you suggest me, where upload this document? I’m also attaching the document and I will be grateful for your opinions.
Leszek Kukiełka
–
You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.
To post to this group, send email to openlmis-dev@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openlmis-dev/0b2dda52-bf84-4fe7-a325-778a5bd3f3d4%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
–
Darius JazayeriPrincipal Architect - Global Health
Email
djazayeri@thoughtworks.com
Telephone
+1 617 383 9369
Agreed. Yesterday I did post a STYLE-GUIDE.md working document (markdown) in the openlmis-template-service repository where we should be posting conventions. If the one file grows too large we can break it up. Lets use that as opposed to the wiki for now.
On Wed, Jun 8, 2016 at 10:36 AM,
lkukielka@soldevelo.com lkukielka@soldevelo.com wrote:
Hello. I have been working on ticket OLMIS-598 and I just wrote quick recommendations for developing unit tests. Could you suggest me, where upload this document? I’m also attaching the document and I will be grateful for your opinions.
Leszek Kukiełka
–
You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.
To post to this group, send email to
openlmis-dev@googlegroups.com.To view this discussion on the web visit
https://groups.google.com/d/msgid/openlmis-dev/0b2dda52-bf84-4fe7-a325-778a5bd3f3d4%40googlegroups.com.For more options, visit
https://groups.google.com/d/optout.
–
Darius JazayeriPrincipal Architect - Global Health
Email
djazayeri@thoughtworks.com
Telephone
+1 617 383 9369
Link: https://github.com/OpenLMIS/openlmis-template-service/blob/master/STYLE-GUIDE.md
On Wed, Jun 8, 2016 at 10:36 AM,
lkukielka@soldevelo.com lkukielka@soldevelo.com wrote:
Hello. I have been working on ticket OLMIS-598 and I just wrote quick recommendations for developing unit tests. Could you suggest me, where upload this document? I’m also attaching the document and I will be grateful for your opinions.
Leszek Kukiełka
–
You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.
To post to this group, send email to
openlmis-dev@googlegroups.com.To view this discussion on the web visit
https://groups.google.com/d/msgid/openlmis-dev/0b2dda52-bf84-4fe7-a325-778a5bd3f3d4%40googlegroups.com.For more options, visit
https://groups.google.com/d/optout.
–
Darius JazayeriPrincipal Architect - Global Health
Email
djazayeri@thoughtworks.com
Telephone
+1 617 383 9369
I just amended amended this style guide. I will be grateful for your opinions.
W dniu czwartek, 9 czerwca 2016 02:33:55 UTC+2 użytkownik Josh Zamor napisał:
Agreed. Yesterday I did post a STYLE-GUIDE.md working document (markdown) in the openlmis-template-service repository where we should be posting conventions. If the one file grows too large we can break it up. Lets use that as opposed to the wiki for now.
On Jun 8, 2016, at 4:24 PM, Darius Jazayeri djaz...@thoughtworks.com wrote:
These should go on the wiki. And rather than “recommendations”, it’s best to think of this as “setting conventions for the OpenLMIS dev community.”
I would advise creating a “Conventions” page either under https://openlmis.atlassian.net/wiki/display/OP/OpenLMIS+Coding+Standards or directly under the Developer Guide page.
Here’s an example from OpenMRS: https://wiki.openmrs.org/x/LwAJ I wouldn’t follow this exactly, but note the idea that there are conventions about quite a few different things.
Also, I would suggest that this goes a lot better with a code example, or even better, if each convention links to a real code example from our code on github, showing how things should be done.
-Darius
On Wed, Jun 8, 2016 at 10:36 AM, > > lkuk...@soldevelo.com lkuk...@soldevelo.com wrote:
Hello. I have been working on ticket OLMIS-598 and I just wrote quick recommendations for developing unit tests. Could you suggest me, where upload this document? I’m also attaching the document and I will be grateful for your opinions.
Leszek Kukiełka
–
You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev...@googlegroups.com.
To post to this group, send email to
openl...@googlegroups.com.To view this discussion on the web visit
https://groups.google.com/d/msgid/openlmis-dev/0b2dda52-bf84-4fe7-a325-778a5bd3f3d4%40googlegroups.com.For more options, visit
https://groups.google.com/d/optout.
–
Darius JazayeriPrincipal Architect - Global Health
djaz...@thoughtworks.com
Telephone
+1 617 383 9369
–
You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.
To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev...@googlegroups.com.
To post to this group, send email to
openl...@googlegroups.com.To view this discussion on the web visit
https://groups.google.com/d/msgid/openlmis-dev/CAOKb-R7P-zdtj%3DzSrQbrHe7a0npJQXrD5qTDZ2mWQWrQPN9zCw%40mail.gmail.com.For more options, visit https://groups.google.com/d/optout.
