What should we do if there is no Approved Quantity while converting to order?

Hi all,

It is currently possible to disable approved quantity in a requisition template. Converting such requisition to order results in 500 error. What should we do in case that field is not present? We probably could either prevent the requisition from converting to order, use a different quantity such as calculated order quantity or requested quantity or treat it as 0. What do you think?

Best regards,

Jakub

Hi Jakub,

Not having the approved quantity field is a feature. That’s my best recollection from previous versions of OpenLMIS at least.

The only option that I believe will be desired for the product’s functionality is the one where either the calculated order quantity or requested quantity are used. Which one will depend on those field’s configurations, certainly.

This is really a question for the product committee, so lets see what they say here before we fix this bug.

What does concern me is where this error popped up. You said it occurs on convert to order? That’s a step where we transition from being in the Requisition service and move to the Fulfillment service. The Requisition Template shouldn’t be known by the Fulfillment service. When I look at the relevant JSON schema used when creating an Order (POST /api/orders):

https://github.com/OpenLMIS/openlmis-fulfillment/blob/master/src/main/resources/schemas/orderLineItemDto.json

I see all of these:

  • approvedQuantity (dispensing unit)
  • orderedQuantity (dispensing unit)
  • packsToShip (actual packages that are being ordered)
  • filledQuantity (what unit is this in? dispensible? packs?)

While we wait on product committee to verify the desired functionality, could someone give an explanation for why we have all these fields in the Order? It would seem to me that we’d only need packsToShip, and filledQuantity would be something more like packsFilled or packsShipped.

···

On Jul 3, 2017, at 10:33 AM, > jkondrat@soldevelo.com wrote:

Hi all,

It is currently possible to disable approved quantity in a requisition template. Converting such requisition to order results in 500 error. What should we do in case that field is not present? We probably could either prevent the requisition from converting to order, use a different quantity such as calculated order quantity or requested quantity or treat it as 0. What do you think?

Best regards,

Jakub

**

SolDevelo** Sp. z o.o. [LLC] /
www.soldevelo.com

Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland

Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41

You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.

To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.

To post to this group, send email to
openlmis-dev@googlegroups.com.

To view this discussion on the web visit
https://groups.google.com/d/msgid/openlmis-dev/00adbf7d-0e50-473f-b990-aacdcf4bbf53%40googlegroups.com
.

For more options, visit https://groups.google.com/d/optout.

Hello Product Committee members,

I have a quick request for input and feedback. Currently, and in previous versions, OpenLMIS allows a user to decide if the Approved Quantity column is displayed (or NOT) on the Report and Requisition via the Requisition Template. Does anyone know if this flexibility was specifically requested by an implementer?

Do any of the current implementations NOT display an approved quantity in the R&R?

Can someone share a use case where a program wouldn’t want the approved quantity column show/used when approving requisitions?

If we still want to provide this option (display/not display), what do we do when we convert the requisition to order when there isn’t an approved quantity?
Right now if approved quantities are not available, there will be an error when trying to convert to order (see Jakub’s initial question).

Please share your comments as soon as possible.

If we don’t have a reason for this flexibility then I’d suggest we do not allow users to unhide/use the approved quantity. Right now the approved quantity is what is used for the order.

Thanks.

@josh – I will bring up your question on Friday during the Product Committee meeting.

···

From: openlmis-dev@googlegroups.com [mailto:openlmis-dev@googlegroups.com] On Behalf Of Josh Zamor

Sent: Monday, July 3, 2017 1:50 PM

To: jkondrat@soldevelo.com

Cc: OpenLMIS Dev openlmis-dev@googlegroups.com

Subject: Re: [openlmis-dev] What should we do if there is no Approved Quantity while converting to order?

Hi Jakub,

Not having the approved quantity field is a feature. That’s my best recollection from previous versions of OpenLMIS at least.

The only option that I believe will be desired for the product’s functionality is the one where either the calculated order quantity or requested quantity are used. Which one will depend on those field’s configurations, certainly.

This is really a question for the product committee, so lets see what they say here before we fix this bug.

What does concern me is where this error popped up. You said it occurs on convert to order? That’s a step where we transition from being in the Requisition service and move to the Fulfillment service. The Requisition Template shouldn’t be known by the Fulfillment service. When I look at the relevant JSON schema used when creating an Order (POST /api/orders):

https://github.com/OpenLMIS/openlmis-fulfillment/blob/master/src/main/resources/schemas/orderLineItemDto.json

I see all of these:

  • approvedQuantity (dispensing unit)

  • orderedQuantity (dispensing unit)

  • packsToShip (actual packages that are being ordered)

  • filledQuantity (what unit is this in? dispensible? packs?)

While we wait on product committee to verify the desired functionality, could someone give an explanation for why we have all these fields in the Order? It would seem to me that we’d only need packsToShip, and filledQuantity would be something more like packsFilled or packsShipped.

On Jul 3, 2017, at 10:33 AM,
jkondrat@soldevelo.com wrote:

Hi all,

It is currently possible to disable approved quantity in a requisition template. Converting such requisition to order results in 500 error. What should we do in case that field is not present? We probably could either prevent the requisition from converting to order, use a different quantity such as calculated order quantity or requested quantity or treat it as 0. What do you think?

Best regards,

Jakub

**

SolDevelo** Sp. z o.o. [LLC] /
www.soldevelo.com

Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland

Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41

You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.

To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.

To post to this group, send email to
openlmis-dev@googlegroups.com.

To view this discussion on the web visit
https://groups.google.com/d/msgid/openlmis-dev/00adbf7d-0e50-473f-b990-aacdcf4bbf53%40googlegroups.com
.

For more options, visit https://groups.google.com/d/optout.

You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.

To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.

To post to this group, send email to
openlmis-dev@googlegroups.com.

To view this discussion on the web visit
https://groups.google.com/d/msgid/openlmis-dev/C4756241-5C77-4538-8258-6CD82CEB6C5E%40villagereach.org
.

For more options, visit https://groups.google.com/d/optout.

Hello,

the Malawi implementation currently does not display approved quantity column for 3 out of 5 programs. This is because those programs won't be using OpenLMIS to order and only submit reporting information monthly (their RnR lifecycle ends at 'APPROVED' status).

In our use case, the initial issue raised by Jakub isn't a problem since we don't convert those requisitions to an order. It is technically possible to configure the system to do that though and this currently results in an error.

Best regards,

Sebastian.
···

On 04.07.2017 02:43, Mary Jo Kochendorfer wrote:

        Hello Product Committee members,
        I have a quick request for input and feedback. Currently, and in previous versions, OpenLMIS allows a user to decide if the Approved Quantity column is displayed (or NOT) on the Report and Requisition via the Requisition Template.                Does anyone know if this flexibility was specifically requested by an implementer?
          Do any of the current implementations NOT display an approved quantity in the R&R?
          Can someone share a use case where a program wouldn’t want the approved quantity column show/used when approving requisitions?
          If we still want to provide this option (display/not display), what do we do when we convert the requisition to order when there isn’t an approved quantity?
        Right now if approved quantities are not available, there will be an error when trying to convert to order (see Jakub’s initial question).
        Please share your comments as soon as possible.
        If we don’t have a reason for this flexibility then I’d suggest we do not allow users to unhide/use the approved quantity.  Right now the approved quantity is what is used for the order.

Thanks.

@josh
– I will bring up your question on Friday during the Product Committee meeting.

From:

            [] Josh Zamor Monday, July 3, 2017 1:50 PM OpenLMIS Dev Re: [openlmis-dev] What should we do if there is no Approved Quantity while converting to order?

Hi Jakub,

        Not having the approved quantity field is a feature.  That’s my best recollection from previous versions of OpenLMIS at least.
        The only option that I believe will be desired for the product’s functionality is the one where either the calculated order quantity or requested quantity are used.  Which one will depend on those field’s configurations, certainly.
        This is really a question for the product committee, so lets see what they say here before we fix this bug.
        What does concern me is where this error popped up.  You said it occurs on convert to order?  That’s a step where we transition from being in the Requisition service and move to the Fulfillment service.  The Requisition Template shouldn’t be known by the Fulfillment service.  When I look at the relevant JSON schema used when creating an Order (POST /api/orders):

https://github.com/OpenLMIS/openlmis-fulfillment/blob/master/src/main/resources/schemas/orderLineItemDto.json

I see all of these:

  • approvedQuantity (dispensing unit)
  • orderedQuantity (dispensing unit)
  • packsToShip (actual packages that are being ordered)
  •           filledQuantity (what unit is this in?  dispensible?  packs?)
    
        While we wait on product committee to verify the desired functionality, could someone give an explanation for why we have all these fields in the Order?  It would seem to me that we’d only need packsToShip, and filledQuantity would be something more like packsFilled or packsShipped.

On Jul 3, 2017, at 10:33 AM,
jkondrat@soldevelo.com wrote:

Hi all,

                  It is currently possible to disable approved quantity in a requisition template. Converting such requisition to order results in 500 error. What should we do in case that field is not present? We probably could either prevent the requisition from converting to order, use a different quantity such as calculated order quantity or requested quantity or treat it as 0. What do you think?

Best regards,

Jakub

              **![](http://www.soldevelo.com/sites/default/files/Soldevelo_logo_EPS_CMYK.png)

                  SolDevelo**
                Sp. z o.o. [LLC] / [
                  www.soldevelo.com](http://www.soldevelo.com/)

                Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland

                Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41

              You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.

              To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.

              To post to this group, send email to
                openlmis-dev@googlegroups.com.

              To view this discussion on the web visit [https://groups.google.com/d/msgid/openlmis-dev/00adbf7d-0e50-473f-b990-aacdcf4bbf53%40googlegroups.com](https://groups.google.com/d/msgid/openlmis-dev/00adbf7d-0e50-473f-b990-aacdcf4bbf53%40googlegroups.com?utm_medium=email&utm_source=footer).

              For more options, visit [https://groups.google.com/d/optout](https://groups.google.com/d/optout).

      You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.

      To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.

      To post to this group, send email to
        openlmis-dev@googlegroups.com.

      To view this discussion on the web visit [https://groups.google.com/d/msgid/openlmis-dev/C4756241-5C77-4538-8258-6CD82CEB6C5E%40villagereach.org](https://groups.google.com/d/msgid/openlmis-dev/C4756241-5C77-4538-8258-6CD82CEB6C5E%40villagereach.org?utm_medium=email&utm_source=footer).

      For more options, visit [https://groups.google.com/d/optout](https://groups.google.com/d/optout).

  You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.

  To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.

  To post to this group, send email to openlmis-dev@googlegroups.com.

  To view this discussion on the web visit [https://groups.google.com/d/msgid/openlmis-dev/BN6PR02MB315455162419715EE346860E8FD70%40BN6PR02MB3154.namprd02.prod.outlook.com](https://groups.google.com/d/msgid/openlmis-dev/BN6PR02MB315455162419715EE346860E8FD70%40BN6PR02MB3154.namprd02.prod.outlook.com?utm_medium=email&utm_source=footer).

  For more options, visit [https://groups.google.com/d/optout](https://groups.google.com/d/optout).


Sebastian Brudziński

    Software Developer / Team Leader


SolDevelo
Sp. z o.o. [LLC] / www.soldevelo.com
Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland
Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41
openlmis-dev@googlegroups.commailto:openlmis-dev@googlegroups.comOn Behalf Of
Sent:
**To:**jkondrat@soldevelo.com
Cc:openlmis-dev@googlegroups.com
Subject:

sbrudzinski@soldevelo.com

Chris thank you for responding to the questions. Alpha do you have any comments? Will either of you be attending the Product Committee meeting tomorrow?

Chris, Would you be willing to share more information on the ‘release without order’ status and when that happens. Is that a manual selection from the user? Or does eLMIS do that if no supply line is associated with the supervisory node?

Thanks,

Mary Jo

···

From: Christopher Opit [mailto:chris_opit@zm.jsi.com]

Sent: Wednesday, July 5, 2017 8:05 PM

To: Mary Jo Kochendorfer maryjo.kochendorfer@villagereach.org; Alpha Nnsaghurwe nalpha@tz.jsi.com

Cc: Ashraf Islam ashraf_islam@jsi.com; Wendy Bomett wendy_bomett@zm.jsi.com

Subject: RE: Re: [openlmis-dev] What should we do if there is no Approved Quantity while converting to order?

When converting a requisition to an order, the reports that will not require to be supplied are selected and the option “release without order” is applied. The status of the report is also changed to “released_without_order”. This differentiates those from other reports that qualify for resupply.

Do any of the current implementations NOT display an approved quantity in the R&R?

ZM displays approved quantity but the new option indicated in the attachment prevents the report from submitting an order to the warehouse.

Can someone share a use case where a program wouldn’t want the approved quantity column show/used when approving requisitions?

If there are two different warehouses under different management. In Zambia we have two warehouses supplying a cross section of facilities with different products but use the same report. As the report and requisition gets first round approval by the district and all the products supplied by warehouse B get “0” posted as approved quantity although requested quantity will remain equal to calculated order quantity. When warehouse A converts the R&R to an order, none of the those commodities are supplied but warehouse B will use requested order quantities to process or adjust their orders.

If we still want to provide this option (display/not display), what do we do when we convert the requisition to order when there isn’t an approved quantity? Right now if approved quantities are not available, there will be an error when trying to convert to order (see Jakub’s initial question).

  •    Would be ok to display but instead auto-populate approved quantity field with a zero (0).
    

From: Mary Jo Kochendorfer [mailto:maryjo.kochendorfer@villagereach.org]

Sent: Tuesday, July 4, 2017 3:13 PM

To: Alpha Nsaghurwe nalpha@tz.jsi.com; chris_opit@zm.jsi.com

Cc: ashraf_islam@jsi.com

Subject: Fwd: Re: [openlmis-dev] What should we do if there is no Approved Quantity while converting to order?

Could either of you weigh in on this question based on your experience?

It would be greatly appreciated.

Get Outlook for Android

From: Sebastian Brudziński

Sent: Tuesday, July 4, 3:03 AM

Subject: Re: [openlmis-dev] What should we do if there is no Approved Quantity while converting to order?

To: Mary Jo Kochendorfer, jkondrat@soldevelo.com, Alpha Nnsaghurwe, Christopher Opit

Cc: OpenLMIS Dev, openlmis_product_committee@googlegroups.com

Hello,

the Malawi implementation currently does not display approved quantity column for 3 out of 5 programs. This is because those programs won’t be using OpenLMIS to order and only submit reporting information monthly (their RnR lifecycle ends at ‘APPROVED’ status).

In our use case, the initial issue raised by Jakub isn’t a problem since we don’t convert those requisitions to an order. It is technically possible to configure the system to do that though and this currently results in an error.

Best regards,

Sebastian.

On 04.07.2017 02:43, Mary Jo Kochendorfer wrote:

Hello Product Committee members,

I have a quick request for input and feedback. Currently, and in previous versions, OpenLMIS allows a user to decide if the Approved Quantity column is displayed (or NOT) on the Report and Requisition via the Requisition Template. Does anyone know if this flexibility was specifically requested by an implementer?

Do any of the current implementations NOT display an approved quantity in the R&R?

Can someone share a use case where a program wouldn’t want the approved quantity column show/used when approving requisitions?

If we still want to provide this option (display/not display), what do we do when we convert the requisition to order when there isn’t an approved quantity? Right now if approved quantities are not available, there will be an error when trying to convert to order (see Jakub’s initial question).

Please share your comments as soon as possible.

If we don’t have a reason for this flexibility then I’d suggest we do not allow users to unhide/use the approved quantity. Right now the approved quantity is what is used for the order.

Thanks.

@josh – I will bring up your question on Friday during the Product Committee meeting.

From:
openlmis-dev@googlegroups.com [mailto:openlmis-dev@googlegroups.com] On Behalf Of Josh Zamor

Sent: Monday, July 3, 2017 1:50 PM

To:
jkondrat@soldevelo.com

Cc: OpenLMIS Dev openlmis-dev@googlegroups.com

Subject: Re: [openlmis-dev] What should we do if there is no Approved Quantity while converting to order?

Hi Jakub,

Not having the approved quantity field is a feature. That’s my best recollection from previous versions of OpenLMIS at least.

The only option that I believe will be desired for the product’s functionality is the one where either the calculated order quantity or requested quantity are used. Which one will depend on those field’s configurations, certainly.

This is really a question for the product committee, so lets see what they say here before we fix this bug.

What does concern me is where this error popped up. You said it occurs on convert to order? That’s a step where we transition from being in the Requisition service and move to the Fulfillment service. The Requisition Template shouldn’t be known by the Fulfillment service. When I look at the relevant JSON schema used when creating an Order (POST /api/orders):

https://github.com/OpenLMIS/openlmis-fulfillment/blob/master/src/main/resources/schemas/orderLineItemDto.json

I see all of these:

approvedQuantity (dispensing unit) orderedQuantity (dispensing unit) packsToShip (actual packages that are being ordered) filledQuantity (what unit is this in? dispensible? packs?)

While we wait on product committee to verify the desired functionality, could someone give an explanation for why we have all these fields in the Order? It would seem to me that we’d only need packsToShip, and filledQuantity would be something more like packsFilled or packsShipped.

On Jul 3, 2017, at 10:33 AM, jkondrat@soldevelo.com wrote:

Hi all,

It is currently possible to disable approved quantity in a requisition template. Converting such requisition to order results in 500 error. What should we do in case that field is not present? We probably could either prevent the requisition from converting to order, use a different quantity such as calculated order quantity or requested quantity or treat it as 0. What do you think?

Best regards,

Jakub

SolDevelo Sp. z o.o. [LLC] / www.soldevelo.com

Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland

Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41

You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.

To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.

To post to this group, send email to openlmis-dev@googlegroups.com.

To view this discussion on the web visit
https://groups.google.com/d/
msgid/openlmis-dev/00adbf7d-0e50-473f-b990-aacdcf4bbf53%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.

To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.

To post to this group, send email to openlmis-dev@googlegroups.com.

To view this discussion on the web visit
https://groups.google.com/d/
msgid/openlmis-dev/C4756241-5C77-4538-8258-6CD82CEB6C5E%40villagereach.org.

For more options, visit https://groups.google.com/d/optout.

You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.

To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.

To post to this group, send email to openlmis-dev@googlegroups.com.

To view this discussion on the web visit
https://groups.google.com/d/
msgid/openlmis-dev/BN6PR02MB315455162419715EE346860E8FD70%40BN6PR02MB3154.namprd02.prod.outlook.com.

For more options, visit https://groups.google.com/d/optout.

Sebastian Brudziński

Software Developer / Team Leader

sbrudzinski@soldevelo.com

SolDevelo Sp. z o.o. [LLC] / www.soldevelo.com

Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland

Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41

I appreciate the additional context Wendy, thanks. I have some follow up questions to make sure I’m understanding the situation.

I’m curious to understand from a technical perspective how the system knows when or when not to set the status.

Are you saying that if Order for February is converted to order and there is an Order for January which hasn’t yet been fulfilled or converted to order, the system automatically releases the Order for January with the “release without order” status? So there is some business logic in the system to searches for all older orders and will convert them without a manual step?

Thank you so much.

···

From: Wendy Bomett [mailto:wendy_bomett@zm.jsi.com]

Sent: Thursday, July 6, 2017 9:42 AM

To: Mary Jo Kochendorfer maryjo.kochendorfer@villagereach.org; Christopher Opit chris_opit@zm.jsi.com; Alpha Nnsaghurwe nalpha@tz.jsi.com

Cc: Ashraf Islam ashraf_islam@jsi.com; openlmis_product_committee@googlegroups.com

Subject: RE: Re: [openlmis-dev] What should we do if there is no Approved Quantity while converting to order?

Hi Mary Jo,

The ‘Release Without Order’ status happens when no resupply is expected for a particular order. For example, if a previous order is preceded by a new order that hasn’t been converted to order then the latest order will be used for the resupply and the older order will be released without an order status.

Regards;

Wendy B.

From: Mary Jo Kochendorfer [mailto:maryjo.kochendorfer@villagereach.org]

Sent: Thursday, July 06, 2017 5:45 PM

To: Christopher Opit; Alpha Nnsaghurwe

Cc: Ashraf Islam; Wendy Bomett;
openlmis_product_committee@googlegroups.com

Subject: RE: Re: [openlmis-dev] What should we do if there is no Approved Quantity while converting to order?

Chris thank you for responding to the questions. Alpha do you have any comments? Will either of you be attending the Product Committee meeting tomorrow?

Chris, Would you be willing to share more information on the ‘release without order’ status and when that happens. Is that a manual selection from the user? Or does eLMIS do that if no supply line is associated with the supervisory node?

Thanks,

Mary Jo

From: Christopher Opit [mailto:chris_opit@zm.jsi.com]

Sent: Wednesday, July 5, 2017 8:05 PM

To: Mary Jo Kochendorfer maryjo.kochendorfer@villagereach.org; Alpha Nnsaghurwe nalpha@tz.jsi.com

Cc: Ashraf Islam ashraf_islam@jsi.com; Wendy Bomett wendy_bomett@zm.jsi.com

Subject: RE: Re: [openlmis-dev] What should we do if there is no Approved Quantity while converting to order?

When converting a requisition to an order, the reports that will not require to be supplied are selected and the option “release without order” is applied. The status of the report is also changed to “released_without_order”. This differentiates those from other reports that qualify for resupply.

Do any of the current implementations NOT display an approved quantity in the R&R?

ZM displays approved quantity but the new option indicated in the attachment prevents the report from submitting an order to the warehouse.

Can someone share a use case where a program wouldn’t want the approved quantity column show/used when approving requisitions?

If there are two different warehouses under different management. In Zambia we have two warehouses supplying a cross section of facilities with different products but use the same report. As the report and requisition gets first round approval by the district and all the products supplied by warehouse B get “0” posted as approved quantity although requested quantity will remain equal to calculated order quantity. When warehouse A converts the R&R to an order, none of the those commodities are supplied but warehouse B will use requested order quantities to process or adjust their orders.

If we still want to provide this option (display/not display), what do we do when we convert the requisition to order when there isn’t an approved quantity? Right now if approved quantities are not available, there will be an error when trying to convert to order (see Jakub’s initial question).

  •    Would be ok to display but instead auto-populate approved quantity field with a zero (0).
    

From: Mary Jo Kochendorfer [mailto:maryjo.kochendorfer@villagereach.org]

Sent: Tuesday, July 4, 2017 3:13 PM

To: Alpha Nsaghurwe nalpha@tz.jsi.com; chris_opit@zm.jsi.com

Cc: ashraf_islam@jsi.com

Subject: Fwd: Re: [openlmis-dev] What should we do if there is no Approved Quantity while converting to order?

Could either of you weigh in on this question based on your experience?

It would be greatly appreciated.

Get Outlook for Android

From: Sebastian Brudziński

Sent: Tuesday, July 4, 3:03 AM

Subject: Re: [openlmis-dev] What should we do if there is no Approved Quantity while converting to order?

To: Mary Jo Kochendorfer, jkondrat@soldevelo.com, Alpha Nnsaghurwe, Christopher Opit

Cc: OpenLMIS Dev, openlmis_product_committee@googlegroups.com

Hello,

the Malawi implementation currently does not display approved quantity column for 3 out of 5 programs. This is because those programs won’t be using OpenLMIS to order and only submit reporting information monthly (their RnR lifecycle ends at ‘APPROVED’ status).

In our use case, the initial issue raised by Jakub isn’t a problem since we don’t convert those requisitions to an order. It is technically possible to configure the system to do that though and this currently results in an error.

Best regards,

Sebastian.

On 04.07.2017 02:43, Mary Jo Kochendorfer wrote:

Hello Product Committee members,

I have a quick request for input and feedback. Currently, and in previous versions, OpenLMIS allows a user to decide if the Approved Quantity column is displayed (or NOT) on the Report and Requisition via the Requisition Template. Does anyone know if this flexibility was specifically requested by an implementer?

Do any of the current implementations NOT display an approved quantity in the R&R?

Can someone share a use case where a program wouldn’t want the approved quantity column show/used when approving requisitions?

If we still want to provide this option (display/not display), what do we do when we convert the requisition to order when there isn’t an approved quantity? Right now if approved quantities are not available, there will be an error when trying to convert to order (see Jakub’s initial question).

Please share your comments as soon as possible.

If we don’t have a reason for this flexibility then I’d suggest we do not allow users to unhide/use the approved quantity. Right now the approved quantity is what is used for the order.

Thanks.

@josh – I will bring up your question on Friday during the Product Committee meeting.

From:
openlmis-dev@googlegroups.com [mailto:openlmis-dev@googlegroups.com] On Behalf Of Josh Zamor

Sent: Monday, July 3, 2017 1:50 PM

To:
jkondrat@soldevelo.com

Cc: OpenLMIS Dev openlmis-dev@googlegroups.com

Subject: Re: [openlmis-dev] What should we do if there is no Approved Quantity while converting to order?

Hi Jakub,

Not having the approved quantity field is a feature. That’s my best recollection from previous versions of OpenLMIS at least.

The only option that I believe will be desired for the product’s functionality is the one where either the calculated order quantity or requested quantity are used. Which one will depend on those field’s configurations, certainly.

This is really a question for the product committee, so lets see what they say here before we fix this bug.

What does concern me is where this error popped up. You said it occurs on convert to order? That’s a step where we transition from being in the Requisition service and move to the Fulfillment service. The Requisition Template shouldn’t be known by the Fulfillment service. When I look at the relevant JSON schema used when creating an Order (POST /api/orders):

https://github.com/OpenLMIS/openlmis-fulfillment/blob/master/src/main/resources/schemas/orderLineItemDto.json

I see all of these:

approvedQuantity (dispensing unit) orderedQuantity (dispensing unit) packsToShip (actual packages that are being ordered) filledQuantity (what unit is this in? dispensible? packs?)

While we wait on product committee to verify the desired functionality, could someone give an explanation for why we have all these fields in the Order? It would seem to me that we’d only need packsToShip, and filledQuantity would be something more like packsFilled or packsShipped.

On Jul 3, 2017, at 10:33 AM, jkondrat@soldevelo.com wrote:

Hi all,

It is currently possible to disable approved quantity in a requisition template. Converting such requisition to order results in 500 error. What should we do in case that field is not present? We probably could either prevent the requisition from converting to order, use a different quantity such as calculated order quantity or requested quantity or treat it as 0. What do you think?

Best regards,

Jakub

SolDevelo Sp. z o.o. [LLC] / www.soldevelo.com

Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland

Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41

You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.

To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.

To post to this group, send email to openlmis-dev@googlegroups.com.

To view this discussion on the web visit
https://groups.google.com/d/
msgid/openlmis-dev/00adbf7d-0e50-473f-b990-aacdcf4bbf53%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.

To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.

To post to this group, send email to openlmis-dev@googlegroups.com.

To view this discussion on the web visit
https://groups.google.com/d/
msgid/openlmis-dev/C4756241-5C77-4538-8258-6CD82CEB6C5E%40villagereach.org.

For more options, visit https://groups.google.com/d/optout.

You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.

To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.

To post to this group, send email to openlmis-dev@googlegroups.com.

To view this discussion on the web visit
https://groups.google.com/d/
msgid/openlmis-dev/BN6PR02MB315455162419715EE346860E8FD70%40BN6PR02MB3154.namprd02.prod.outlook.com.

For more options, visit https://groups.google.com/d/optout.

Sebastian Brudziński

Software Developer / Team Leader

sbrudzinski@soldevelo.com

SolDevelo Sp. z o.o. [LLC] / www.soldevelo.com

Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland

Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41

Great to know, thank you. It would be great if this feature could be further documented as it is not included version 3. Perhaps someone could provide some screen shots of the how the user selects the option.

Thanks.

Adding the PATH team so they can make sure to include this feature in the gap analysis work.

···

From: Wendy Bomett [mailto:wendy_bomett@zm.jsi.com]

Sent: Thursday, July 6, 2017 10:44 AM

To: Mary Jo Kochendorfer maryjo.kochendorfer@villagereach.org; Christopher Opit chris_opit@zm.jsi.com; Alpha Nnsaghurwe nalpha@tz.jsi.com

Cc: Ashraf Islam ashraf_islam@jsi.com; openlmis_product_committee@googlegroups.com

Subject: RE: Re: [openlmis-dev] What should we do if there is no Approved Quantity while converting to order?

Hi Mary Jo,

Currently the function is user driven, the logic is exactly as you stated it the only difference is that when there are two orders from the same facility for the same program area but for separate months, the LMU user selects the older order and submits those as ‘release without order’. There is an enhancement in the pipeline that will allow for this process to be automated.

Regards;

Wendy B.

From: Mary Jo Kochendorfer [mailto:maryjo.kochendorfer@villagereach.org]

Sent: Thursday, July 06, 2017 7:27 PM

To: Wendy Bomett; Christopher Opit; Alpha Nnsaghurwe

Cc: Ashraf Islam;
openlmis_product_committee@googlegroups.com

Subject: RE: Re: [openlmis-dev] What should we do if there is no Approved Quantity while converting to order?

I appreciate the additional context Wendy, thanks. I have some follow up questions to make sure I’m understanding the situation.

I’m curious to understand from a technical perspective how the system knows when or when not to set the status.

Are you saying that if Order for February is converted to order and there is an Order for January which hasn’t yet been fulfilled or converted to order, the system automatically releases the Order for January with the “release without order” status? So there is some business logic in the system to searches for all older orders and will convert them without a manual step?

Thank you so much.

From: Wendy Bomett [mailto:wendy_bomett@zm.jsi.com]

Sent: Thursday, July 6, 2017 9:42 AM

To: Mary Jo Kochendorfer maryjo.kochendorfer@villagereach.org; Christopher Opit chris_opit@zm.jsi.com; Alpha Nnsaghurwe nalpha@tz.jsi.com

Cc: Ashraf Islam ashraf_islam@jsi.com; openlmis_product_committee@googlegroups.com

Subject: RE: Re: [openlmis-dev] What should we do if there is no Approved Quantity while converting to order?

Hi Mary Jo,

The ‘Release Without Order’ status happens when no resupply is expected for a particular order. For example, if a previous order is preceded by a new order that hasn’t been converted to order then the latest order will be used for the resupply and the older order will be released without an order status.

Regards;

Wendy B.

From: Mary Jo Kochendorfer [mailto:maryjo.kochendorfer@villagereach.org]

Sent: Thursday, July 06, 2017 5:45 PM

To: Christopher Opit; Alpha Nnsaghurwe

Cc: Ashraf Islam; Wendy Bomett;
openlmis_product_committee@googlegroups.com

Subject: RE: Re: [openlmis-dev] What should we do if there is no Approved Quantity while converting to order?

Chris thank you for responding to the questions. Alpha do you have any comments? Will either of you be attending the Product Committee meeting tomorrow?

Chris, Would you be willing to share more information on the ‘release without order’ status and when that happens. Is that a manual selection from the user? Or does eLMIS do that if no supply line is associated with the supervisory node?

Thanks,

Mary Jo

From: Christopher Opit [mailto:chris_opit@zm.jsi.com]

Sent: Wednesday, July 5, 2017 8:05 PM

To: Mary Jo Kochendorfer maryjo.kochendorfer@villagereach.org; Alpha Nnsaghurwe nalpha@tz.jsi.com

Cc: Ashraf Islam ashraf_islam@jsi.com; Wendy Bomett wendy_bomett@zm.jsi.com

Subject: RE: Re: [openlmis-dev] What should we do if there is no Approved Quantity while converting to order?

When converting a requisition to an order, the reports that will not require to be supplied are selected and the option “release without order” is applied. The status of the report is also changed to “released_without_order”. This differentiates those from other reports that qualify for resupply.

Do any of the current implementations NOT display an approved quantity in the R&R?

ZM displays approved quantity but the new option indicated in the attachment prevents the report from submitting an order to the warehouse.

Can someone share a use case where a program wouldn’t want the approved quantity column show/used when approving requisitions?

If there are two different warehouses under different management. In Zambia we have two warehouses supplying a cross section of facilities with different products but use the same report. As the report and requisition gets first round approval by the district and all the products supplied by warehouse B get “0” posted as approved quantity although requested quantity will remain equal to calculated order quantity. When warehouse A converts the R&R to an order, none of the those commodities are supplied but warehouse B will use requested order quantities to process or adjust their orders.

If we still want to provide this option (display/not display), what do we do when we convert the requisition to order when there isn’t an approved quantity? Right now if approved quantities are not available, there will be an error when trying to convert to order (see Jakub’s initial question).

  •    Would be ok to display but instead auto-populate approved quantity field with a zero (0).
    

From: Mary Jo Kochendorfer [mailto:maryjo.kochendorfer@villagereach.org]

Sent: Tuesday, July 4, 2017 3:13 PM

To: Alpha Nsaghurwe nalpha@tz.jsi.com; chris_opit@zm.jsi.com

Cc: ashraf_islam@jsi.com

Subject: Fwd: Re: [openlmis-dev] What should we do if there is no Approved Quantity while converting to order?

Could either of you weigh in on this question based on your experience?

It would be greatly appreciated.

Get Outlook for Android

From: Sebastian Brudziński

Sent: Tuesday, July 4, 3:03 AM

Subject: Re: [openlmis-dev] What should we do if there is no Approved Quantity while converting to order?

To: Mary Jo Kochendorfer, jkondrat@soldevelo.com, Alpha Nnsaghurwe, Christopher Opit

Cc: OpenLMIS Dev, openlmis_product_committee@googlegroups.com

Hello,

the Malawi implementation currently does not display approved quantity column for 3 out of 5 programs. This is because those programs won’t be using OpenLMIS to order and only submit reporting information monthly (their RnR lifecycle ends at ‘APPROVED’ status).

In our use case, the initial issue raised by Jakub isn’t a problem since we don’t convert those requisitions to an order. It is technically possible to configure the system to do that though and this currently results in an error.

Best regards,

Sebastian.

On 04.07.2017 02:43, Mary Jo Kochendorfer wrote:

Hello Product Committee members,

I have a quick request for input and feedback. Currently, and in previous versions, OpenLMIS allows a user to decide if the Approved Quantity column is displayed (or NOT) on the Report and Requisition via the Requisition Template. Does anyone know if this flexibility was specifically requested by an implementer?

Do any of the current implementations NOT display an approved quantity in the R&R?

Can someone share a use case where a program wouldn’t want the approved quantity column show/used when approving requisitions?

If we still want to provide this option (display/not display), what do we do when we convert the requisition to order when there isn’t an approved quantity? Right now if approved quantities are not available, there will be an error when trying to convert to order (see Jakub’s initial question).

Please share your comments as soon as possible.

If we don’t have a reason for this flexibility then I’d suggest we do not allow users to unhide/use the approved quantity. Right now the approved quantity is what is used for the order.

Thanks.

@josh – I will bring up your question on Friday during the Product Committee meeting.

From:
openlmis-dev@googlegroups.com [mailto:openlmis-dev@googlegroups.com] On Behalf Of Josh Zamor

Sent: Monday, July 3, 2017 1:50 PM

To:
jkondrat@soldevelo.com

Cc: OpenLMIS Dev openlmis-dev@googlegroups.com

Subject: Re: [openlmis-dev] What should we do if there is no Approved Quantity while converting to order?

Hi Jakub,

Not having the approved quantity field is a feature. That’s my best recollection from previous versions of OpenLMIS at least.

The only option that I believe will be desired for the product’s functionality is the one where either the calculated order quantity or requested quantity are used. Which one will depend on those field’s configurations, certainly.

This is really a question for the product committee, so lets see what they say here before we fix this bug.

What does concern me is where this error popped up. You said it occurs on convert to order? That’s a step where we transition from being in the Requisition service and move to the Fulfillment service. The Requisition Template shouldn’t be known by the Fulfillment service. When I look at the relevant JSON schema used when creating an Order (POST /api/orders):

https://github.com/OpenLMIS/openlmis-fulfillment/blob/master/src/main/resources/schemas/orderLineItemDto.json

I see all of these:

approvedQuantity (dispensing unit) orderedQuantity (dispensing unit) packsToShip (actual packages that are being ordered) filledQuantity (what unit is this in? dispensible? packs?)

While we wait on product committee to verify the desired functionality, could someone give an explanation for why we have all these fields in the Order? It would seem to me that we’d only need packsToShip, and filledQuantity would be something more like packsFilled or packsShipped.

On Jul 3, 2017, at 10:33 AM, jkondrat@soldevelo.com wrote:

Hi all,

It is currently possible to disable approved quantity in a requisition template. Converting such requisition to order results in 500 error. What should we do in case that field is not present? We probably could either prevent the requisition from converting to order, use a different quantity such as calculated order quantity or requested quantity or treat it as 0. What do you think?

Best regards,

Jakub

SolDevelo Sp. z o.o. [LLC] / www.soldevelo.com

Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland

Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41

You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.

To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.

To post to this group, send email to openlmis-dev@googlegroups.com.

To view this discussion on the web visit
https://groups.google.com/d/
msgid/openlmis-dev/00adbf7d-0e50-473f-b990-aacdcf4bbf53%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.

To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.

To post to this group, send email to openlmis-dev@googlegroups.com.

To view this discussion on the web visit
https://groups.google.com/d/
msgid/openlmis-dev/C4756241-5C77-4538-8258-6CD82CEB6C5E%40villagereach.org.

For more options, visit https://groups.google.com/d/optout.

You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.

To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.

To post to this group, send email to openlmis-dev@googlegroups.com.

To view this discussion on the web visit
https://groups.google.com/d/
msgid/openlmis-dev/BN6PR02MB315455162419715EE346860E8FD70%40BN6PR02MB3154.namprd02.prod.outlook.com.

For more options, visit https://groups.google.com/d/optout.

Sebastian Brudziński

Software Developer / Team Leader

sbrudzinski@soldevelo.com

SolDevelo Sp. z o.o. [LLC] / www.soldevelo.com

Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland

Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41

Hi all

@Josh: I agree that we could remove some of these fields from OrderLineItem. For example, approvedQuantity doesn’t seem to be used anywhere. I created a ticket to track this: https://openlmis.atlassian.net/browse/OLMIS-2932

@Mary: Did you have a chance to ask the Product Committee these questions? That would be really helpful.

Best Regards,

Jakub

···

On Tuesday, July 4, 2017 at 2:43:06 AM UTC+2, Mary Jo Kochendorfer wrote:

Hello Product Committee members,

I have a quick request for input and feedback. Currently, and in previous versions, OpenLMIS allows a user to decide if the Approved Quantity column is displayed (or NOT) on the Report and Requisition via the Requisition Template. Does anyone know if this flexibility was specifically requested by an implementer?

Do any of the current implementations NOT display an approved quantity in the R&R?

Can someone share a use case where a program wouldn’t want the approved quantity column show/used when approving requisitions?

If we still want to provide this option (display/not display), what do we do when we convert the requisition to order when there isn’t an approved quantity?
Right now if approved quantities are not available, there will be an error when trying to convert to order (see Jakub’s initial question).

Please share your comments as soon as possible.

If we don’t have a reason for this flexibility then I’d suggest we do not allow users to unhide/use the approved quantity. Right now the approved quantity is what is used for the order.

Thanks.

@josh – I will bring up your question on Friday during the Product Committee meeting.

From: openlm...@googlegroups.com [mailto:openlm...@googlegroups.com] On Behalf Of Josh Zamor

Sent: Monday, July 3, 2017 1:50 PM

To: jkon...@soldevelo.com

Cc: OpenLMIS Dev openlm...@googlegroups.com

Subject: Re: [openlmis-dev] What should we do if there is no Approved Quantity while converting to order?

Hi Jakub,

Not having the approved quantity field is a feature. That’s my best recollection from previous versions of OpenLMIS at least.

The only option that I believe will be desired for the product’s functionality is the one where either the calculated order quantity or requested quantity are used. Which one will depend on those field’s configurations, certainly.

This is really a question for the product committee, so lets see what they say here before we fix this bug.

What does concern me is where this error popped up. You said it occurs on convert to order? That’s a step where we transition from being in the Requisition service and move to the Fulfillment service. The Requisition Template shouldn’t be known by the Fulfillment service. When I look at the relevant JSON schema used when creating an Order (POST /api/orders):

https://github.com/OpenLMIS/openlmis-fulfillment/blob/master/src/main/resources/schemas/orderLineItemDto.json

I see all of these:

  • approvedQuantity (dispensing unit)
  • orderedQuantity (dispensing unit)
  • packsToShip (actual packages that are being ordered)
  • filledQuantity (what unit is this in? dispensible? packs?)

While we wait on product committee to verify the desired functionality, could someone give an explanation for why we have all these fields in the Order? It would seem to me that we’d only need packsToShip, and filledQuantity would be something more like packsFilled or packsShipped.

On Jul 3, 2017, at 10:33 AM, > > jko...@soldevelo.com wrote:

Hi all,

It is currently possible to disable approved quantity in a requisition template. Converting such requisition to order results in 500 error. What should we do in case that field is not present? We probably could either prevent the requisition from converting to order, use a different quantity such as calculated order quantity or requested quantity or treat it as 0. What do you think?

Best regards,

Jakub

**

SolDevelo** Sp. z o.o. [LLC] /
www.soldevelo.com

Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland

Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41

You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.

To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev...@googlegroups.com.

To post to this group, send email to
openl...@googlegroups.com.

To view this discussion on the web visit
https://groups.google.com/d/msgid/openlmis-dev/00adbf7d-0e50-473f-b990-aacdcf4bbf53%40googlegroups.com
.

For more options, visit https://groups.google.com/d/optout.

You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.

To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev...@googlegroups.com.

To post to this group, send email to
openl...@googlegroups.com.

To view this discussion on the web visit
https://groups.google.com/d/msgid/openlmis-dev/C4756241-5C77-4538-8258-6CD82CEB6C5E%40villagereach.org
.

For more options, visit https://groups.google.com/d/optout.

Hello Jakub,

Yes, Chris and the team in Zambia provided additional information. No one indicated that a requisition is created without displaying the approved quantity amounts besides Malawi. Malawi doesn’t show the approved quantity in the requisition process because it is only using the reporting aspect of the requisition versus creating an order for fulfillment.

There was discussion around how there is a need for an order to be potentially split between two supplying warehouses, but that is new functionality versus currently implemented in version 3. Zambia also added another order status which is converting a requisition that is not intended to be fulfilled and does not go to the supplying facility, it is called “released without order”. This happens when the requisition will not be filled for some reason.

Thank you for creating the ticket to track the conversation. I will update it with my comments.

Thanks,

Mary Jo

···

On Aug 2, 2017, at 7:16 AM, > jkondrat@soldevelo.com wrote:

Hi all

@Josh: I agree that we could remove some of these fields from OrderLineItem. For example, approvedQuantity doesn’t seem to be used anywhere. I created a ticket to track this: https://openlmis.atlassian.net/browse/OLMIS-2932

@Mary: Did you have a chance to ask the Product Committee these questions? That would be really helpful.

Best Regards,

Jakub

On Tuesday, July 4, 2017 at 2:43:06 AM UTC+2, Mary Jo Kochendorfer wrote:

Hello Product Committee members,

I have a quick request for input and feedback. Currently, and in previous versions, OpenLMIS allows a user to decide if the Approved Quantity column is displayed (or NOT) on the Report and Requisition via the Requisition Template. Does anyone know if this flexibility was specifically requested by an implementer?

Do any of the current implementations NOT display an approved quantity in the R&R?

Can someone share a use case where a program wouldn’t want the approved quantity column show/used when approving requisitions?

If we still want to provide this option (display/not display), what do we do when we convert the requisition to order when there isn’t an approved quantity? Right now if approved quantities are not available, there will be an error when trying to convert to order (see Jakub’s initial question).

Please share your comments as soon as possible.

If we don’t have a reason for this flexibility then I’d suggest we do not allow users to unhide/use the approved quantity. Right now the approved quantity is what is used for the order.

Thanks.

@josh – I will bring up your question on Friday during the Product Committee meeting.

From:

openlm...@googlegroups.com [mailto:openlm...@googlegroups.com] On Behalf Of Josh Zamor

Sent: Monday, July 3, 2017 1:50 PM

To:
jkon...@soldevelo.com

Cc: OpenLMIS Dev openlm...@googlegroups.com

Subject: Re: [openlmis-dev] What should we do if there is no Approved Quantity while converting to order?

Hi Jakub,

Not having the approved quantity field is a feature. That’s my best recollection from previous versions of OpenLMIS at least.

The only option that I believe will be desired for the product’s functionality is the one where either the calculated order quantity or requested quantity are used. Which one will depend on those field’s configurations, certainly.

This is really a question for the product committee, so lets see what they say here before we fix this bug.

What does concern me is where this error popped up. You said it occurs on convert to order? That’s a step where we transition from being in the Requisition service and move to the Fulfillment service. The Requisition Template shouldn’t be known by the Fulfillment service. When I look at the relevant JSON schema used when creating an Order (POST /api/orders):

https://github.com/OpenLMIS/openlmis-fulfillment/blob/master/src/main/resources/schemas/orderLineItemDto.json

I see all of these:

  • approvedQuantity (dispensing unit)
  • orderedQuantity (dispensing unit)
  • packsToShip (actual packages that are being ordered)
  • filledQuantity (what unit is this in? dispensible? packs?)

While we wait on product committee to verify the desired functionality, could someone give an explanation for why we have all these fields in the Order? It would seem to me that we’d only need packsToShip, and filledQuantity would be something more like packsFilled or packsShipped.

On Jul 3, 2017, at 10:33 AM, > > > jko...@soldevelo.com wrote:

Hi all,

It is currently possible to disable approved quantity in a requisition template. Converting such requisition to order results in 500 error. What should we do in case that field is not present? We probably could either prevent the requisition from converting to order, use a different quantity such as calculated order quantity or requested quantity or treat it as 0. What do you think?

Best regards,

Jakub

**

SolDevelo** Sp. z o.o. [LLC] /
www.soldevelo.com

Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland

Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41

You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.

To unsubscribe from this group and stop receiving emails from it, send an email to
openlmis-dev...@googlegroups.com.

To post to this group, send email to
openl...@googlegroups.com.

To view this discussion on the web visit
https://groups.google.com/d/msgid/openlmis-dev/00adbf7d-0e50-473f-b990-aacdcf4bbf53%40googlegroups.com
.

For more options, visit
https://groups.google.com/d/optout
.

You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.

To unsubscribe from this group and stop receiving emails from it, send an email to
openlmis-dev...@googlegroups.com.

To post to this group, send email to
openl...@googlegroups.com.

To view this discussion on the web visit
https://groups.google.com/d/msgid/openlmis-dev/C4756241-5C77-4538-8258-6CD82CEB6C5E%40villagereach.org
.

For more options, visit
https://groups.google.com/d/optout
.

**

SolDevelo** Sp. z o.o. [LLC] /
www.soldevelo.com

Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland

Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41

You received this message because you are subscribed to the Google Groups “OpenLMIS Dev” group.

To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.

To post to this group, send email to
openlmis-dev@googlegroups.com.

To view this discussion on the web visit
https://groups.google.com/d/msgid/openlmis-dev/1df1a269-8f06-48be-9686-aeb7a6c96704%40googlegroups.com
.

For more options, visit https://groups.google.com/d/optout.

Hi Mary Jo,

  based on PC feedback, what would be your recommendation for converting to an order requisitions that do not have approved quantity field enabled in the requisition template? Should there be a validation at the convert to order step and an error returned if there's an attempt to do so? We could also add a warning on the requisition template configuration UI, when disabling the approved quantity, something along the lines: "You will not be able to convert a requisition to an order, if approved quantity is not enabled".

  A more advanced approach could be to fallback to calculated order quantity or requested quantity (in that order?) if you think that is more desirable.

Thanks,

  Sebastian.
···

On 08.08.2017 01:38, Mary Jo Kochendorfer wrote:

Hello Jakub,

    Yes, Chris and the team in Zambia provided additional information. No one indicated that a requisition is created without displaying the approved quantity amounts besides Malawi. Malawi doesn’t show the approved quantity in the requisition process because it is only using the reporting aspect of the requisition versus creating an order for fulfillment.
    There was discussion around how there is a need for an order to be potentially split between two supplying warehouses, but that is new functionality versus currently implemented in version 3.  Zambia also added another order status which is converting a requisition that is not intended to be fulfilled and does not go to the supplying facility, it is called “released without order”. This happens when the requisition will not be filled for some reason.
    Thank you for creating the ticket to track the conversation. I will update it with my comments.

Thanks,

Mary Jo

On Aug 2, 2017, at 7:16 AM,
jkondrat@soldevelo.com wrote:

Hi all

            @Josh: I agree that we could remove some of these fields from OrderLineItem. For example, approvedQuantity doesn't seem to be used anywhere. I created a ticket to track this: [https://openlmis.atlassian.net/browse/OLMIS-2932](https://openlmis.atlassian.net/browse/OLMIS-2932)
              @Mary: Did you have a chance to ask the Product Committee these questions? That would be really helpful.

Best Regards,

Jakub

              On Tuesday, July 4, 2017 at 2:43:06 AM UTC+2, Mary Jo Kochendorfer wrote:

Hello Product Committee members,

                        I have a quick request for input and feedback. Currently, and in previous versions, OpenLMIS allows a user to decide if the Approved Quantity column is displayed (or NOT) on the Report and Requisition via the Requisition Template.                                Does anyone know if this flexibility was specifically requested by an implementer?
                          Do any of the current implementations NOT display an approved quantity in the R&R?
                          Can someone share a use case where a program wouldn’t want the approved quantity column show/used when approving requisitions?
                          If we still want to provide this option (display/not display), what do we do when we convert the requisition to order when there isn’t an approved quantity? Right now if approved quantities are not available, there will be an error when trying to convert to order (see Jakub’s initial question).
                        Please share your comments as soon as possible.
                        If we don’t have a reason for this flexibility then I’d suggest we do not allow users to unhide/use the approved quantity.  Right now the approved quantity is what is used for the order.

Thanks.

@josh – I will bring up your question on Friday during the Product Committee meeting.

From:

                              openlm...@googlegroups.com
                            [mailto:openlm...@googlegroups.com                                ] **On Behalf Of** Josh Zamor

                            **Sent:** Monday, July 3, 2017 1:50 PM

                            **To:**
                              jkon...@soldevelo.com

                            **Cc:** OpenLMIS Dev <openlm...@googlegroups.com>

                            **Subject:** Re: [openlmis-dev] What should we do if there is no Approved Quantity while converting to order?

Hi Jakub,

                        Not having the approved quantity field is a feature.  That’s my best recollection from previous versions of OpenLMIS at least.
                        The only option that I believe will be desired for the product’s functionality is the one where either the calculated order quantity or requested quantity are used.  Which one will depend on those field’s configurations, certainly.
                        This is really a question for the product committee, so lets see what they say here before we fix this bug.
                        What does concern me is where this error popped up.  You said it occurs on convert to order?  That’s a step where we transition from being in the Requisition service and move to the Fulfillment service.  The Requisition Template shouldn’t be known by the Fulfillment service.  When I look at the relevant JSON schema used when creating an Order (POST /api/orders):

https://github.com/OpenLMIS/openlmis-fulfillment/blob/master/src/main/resources/schemas/orderLineItemDto.json

I see all of these:

  •                           approvedQuantity (dispensing unit)
    
  •                           orderedQuantity (dispensing unit)
    
  •                           packsToShip (actual packages that are being ordered)
    
  •                           filledQuantity (what unit is this in?  dispensible?  packs?)
    
                        While we wait on product committee to verify the desired functionality, could someone give an explanation for why we have all these fields in the Order?  It would seem to me that we’d only need packsToShip, and filledQuantity would be something more like packsFilled or packsShipped.
                              On Jul 3, 2017, at 10:33 AM,
                                jko...@soldevelo.com wrote:

Hi all,

                                  It is currently possible to disable approved quantity in a requisition template. Converting such requisition to order results in 500 error. What should we do in case that field is not present? We probably could either prevent the requisition from converting to order, use a different quantity such as calculated order quantity or requested quantity or treat it as 0. What do you think?

Best regards,

Jakub

                              **![](https://lh3.googleusercontent.com/proxy/Kq7icsK3MEQjYLwBW84HwuYjQ8aFuyyirMOzt_ENZ5BgyyRVaFVgsbO-vnqZPEKtkcm1Gs2mKJSDSi59adej7wSt1KiO3u5QJa2SfrMvGRh8cyONHJScEXiljA=w5000-h5000)

                                  SolDevelo**
                                Sp. z o.o. [LLC] / [
                                  www.soldevelo.com](http://www.soldevelo.com/)

                                Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland

                                Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41

                              You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.

                              To unsubscribe from this group and stop receiving emails from it, send an email to
                                openlmis-dev...@googlegroups.com.

                              To post to this group, send email to
                                openl...@googlegroups.com.

                              To view this discussion on the web visit [
                                https://groups.google.com/d/msgid/openlmis-dev/00adbf7d-0e50-473f-b990-aacdcf4bbf53%40googlegroups.com](https://groups.google.com/d/msgid/openlmis-dev/00adbf7d-0e50-473f-b990-aacdcf4bbf53%40googlegroups.com?utm_medium=email&utm_source=footer).

                              For more options, visit [
                                https://groups.google.com/d/optout](https://groups.google.com/d/optout).

                      You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.

                      To unsubscribe from this group and stop receiving emails from it, send an email to
                        openlmis-dev...@googlegroups.com.

                      To post to this group, send email to
                        openl...@googlegroups.com.

                      To view this discussion on the web visit [
                        https://groups.google.com/d/msgid/openlmis-dev/C4756241-5C77-4538-8258-6CD82CEB6C5E%40villagereach.org](https://groups.google.com/d/msgid/openlmis-dev/C4756241-5C77-4538-8258-6CD82CEB6C5E%40villagereach.org?utm_medium=email&utm_source=footer).

                      For more options, visit [
                        https://groups.google.com/d/optout](https://groups.google.com/d/optout).
        **![](http://www.soldevelo.com/sites/default/files/Soldevelo_logo_EPS_CMYK.png)

            SolDevelo** Sp. z o.o. [LLC] / [
            www.soldevelo.com](http://www.soldevelo.com/)

          Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland

          Phone:                 +48 58 782 45 40 / Fax:                 +48 58 782 45 41

        You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.

        To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.

        To post to this group, send email to
          openlmis-dev@googlegroups.com.

        To view this discussion on the web visit [

https://groups.google.com/d/msgid/openlmis-dev/1df1a269-8f06-48be-9686-aeb7a6c96704%40googlegroups.com](https://groups.google.com/d/msgid/openlmis-dev/1df1a269-8f06-48be-9686-aeb7a6c96704%40googlegroups.com?utm_medium=email&utm_source=footer).

        For more options, visit [https://groups.google.com/d/optout](https://groups.google.com/d/optout).
  --

  You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.

  To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev+unsubscribe@googlegroups.com.

  To post to this group, send email to openlmis-dev@googlegroups.com.

  To view this discussion on the web visit [https://groups.google.com/d/msgid/openlmis-dev/921D23AE-398B-471B-AAFB-9FEC7739592D%40villagereach.org](https://groups.google.com/d/msgid/openlmis-dev/921D23AE-398B-471B-AAFB-9FEC7739592D%40villagereach.org?utm_medium=email&utm_source=footer).

  For more options, visit [https://groups.google.com/d/optout](https://groups.google.com/d/optout).


Sebastian Brudziński

    Software Developer / Team Leader


SolDevelo
Sp. z o.o. [LLC] / www.soldevelo.com
Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland
Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41
sbrudzinski@soldevelo.com

Hi Sebastian,

We’ve talked about this with Mary and she says it makes sense to have some kind of validation. We could show up a meaningful error when the user tries converting such requisition to an order.

Best regards,

Jakub

···

On Thursday, August 10, 2017 at 10:42:18 AM UTC+2, Sebastian Brudziński wrote:

Hi Mary Jo,

  based on PC feedback, what would be your recommendation for converting to an order requisitions that do not have approved quantity field enabled in the requisition template? Should there be a validation at the convert to order step and an error returned if there's an attempt to do so? We could also add a warning on the requisition template configuration UI, when disabling the approved quantity, something along the lines: "You will not be able to convert a requisition to an order, if approved quantity is not enabled".
  A more advanced approach could be to fallback to calculated order quantity or requested quantity (in that order?) if you think that is more desirable.

Thanks,

  Sebastian.
  On 08.08.2017 01:38, Mary Jo Kochendorfer wrote:

Hello Jakub,

    Yes, Chris and the team in Zambia provided additional information. No one indicated that a requisition is created without displaying the approved quantity amounts besides Malawi. Malawi doesn’t show the approved quantity in the requisition process because it is only using the reporting aspect of the requisition versus creating an order for fulfillment.
    There was discussion around how there is a need for an order to be potentially split between two supplying warehouses, but that is new functionality versus currently implemented in version 3.  Zambia also added another order status which is converting a requisition that is not intended to be fulfilled and does not go to the supplying facility, it is called “released without order”. This happens when the requisition will not be filled for some reason.
    Thank you for creating the ticket to track the conversation. I will update it with my comments.

Thanks,

Mary Jo

On Aug 2, 2017, at 7:16 AM, > > > ...@soldevelo.com wrote:

Hi all

            @Josh: I agree that we could remove some of these fields from OrderLineItem. For example, approvedQuantity doesn't seem to be used anywhere. I created a ticket to track this: [https://openlmis.atlassian.net/browse/OLMIS-2932](https://openlmis.atlassian.net/browse/OLMIS-2932)
              @Mary: Did you have a chance to ask the Product Committee these questions? That would be really helpful.

Best Regards,

Jakub

              On Tuesday, July 4, 2017 at 2:43:06 AM UTC+2, Mary Jo Kochendorfer wrote:

Hello Product Committee members,

                        I have a quick request for input and feedback. Currently, and in previous versions, OpenLMIS allows a user to decide if the Approved Quantity column is displayed (or NOT) on the Report and Requisition via the Requisition Template.                                Does anyone know if this flexibility was specifically requested by an implementer?
                          Do any of the current implementations NOT display an approved quantity in the R&R?
                          Can someone share a use case where a program wouldn’t want the approved quantity column show/used when approving requisitions?
                          If we still want to provide this option (display/not display), what do we do when we convert the requisition to order when there isn’t an approved quantity? Right now if approved quantities are not available, there will be an error when trying to convert to order (see Jakub’s initial question).
                        Please share your comments as soon as possible.
                        If we don’t have a reason for this flexibility then I’d suggest we do not allow users to unhide/use the approved quantity.  Right now the approved quantity is what is used for the order.

Thanks.

@josh – I will bring up your question on Friday during the Product Committee meeting.

From:

                              openlm...@googlegroups.com
                            [mailto:openlm...@googlegroups.com                                ] **On Behalf Of** Josh Zamor

                            **Sent:** Monday, July 3, 2017 1:50 PM

                            **To:**
                              jkon...@soldevelo.com

                            **Cc:** OpenLMIS Dev <openlm...@googlegroups.com>

                            **Subject:** Re: [openlmis-dev] What should we do if there is no Approved Quantity while converting to order?

Hi Jakub,

                        Not having the approved quantity field is a feature.  That’s my best recollection from previous versions of OpenLMIS at least.
                        The only option that I believe will be desired for the product’s functionality is the one where either the calculated order quantity or requested quantity are used.  Which one will depend on those field’s configurations, certainly.
                        This is really a question for the product committee, so lets see what they say here before we fix this bug.
                        What does concern me is where this error popped up.  You said it occurs on convert to order?  That’s a step where we transition from being in the Requisition service and move to the Fulfillment service.  The Requisition Template shouldn’t be known by the Fulfillment service.  When I look at the relevant JSON schema used when creating an Order (POST /api/orders):

https://github.com/OpenLMIS/openlmis-fulfillment/blob/master/src/main/resources/schemas/orderLineItemDto.json

I see all of these:

  •                           approvedQuantity (dispensing unit)
    
  •                           orderedQuantity (dispensing unit)
    
  •                           packsToShip (actual packages that are being ordered)
    
  •                           filledQuantity (what unit is this in?  dispensible?  packs?)
    
                        While we wait on product committee to verify the desired functionality, could someone give an explanation for why we have all these fields in the Order?  It would seem to me that we’d only need packsToShip, and filledQuantity would be something more like packsFilled or packsShipped.
                              On Jul 3, 2017, at 10:33 AM, > > > > >                                     jko...@soldevelo.com wrote:

Hi all,

                                  It is currently possible to disable approved quantity in a requisition template. Converting such requisition to order results in 500 error. What should we do in case that field is not present? We probably could either prevent the requisition from converting to order, use a different quantity such as calculated order quantity or requested quantity or treat it as 0. What do you think?

Best regards,

Jakub

                              **<img style="width:1.5104in;min-height:.3645in" src="https://lh3.googleusercontent.com/proxy/Kq7icsK3MEQjYLwBW84HwuYjQ8aFuyyirMOzt_ENZ5BgyyRVaFVgsbO-vnqZPEKtkcm1Gs2mKJSDSi59adej7wSt1KiO3u5QJa2SfrMvGRh8cyONHJScEXiljA=w5000-h5000" border="0" height="35" width="145">

                                  SolDevelo**
                                Sp. z o.o. [LLC] / [
                                  www.soldevelo.com](http://www.soldevelo.com/)

                                Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland

                                Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41

                              You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.

                              To unsubscribe from this group and stop receiving emails from it, send an email to
                                openlmis-dev...@googlegroups.com.

                              To post to this group, send email to
                                openl...@googlegroups.com.

                              To view this discussion on the web visit [
                                https://groups.google.com/d/msgid/openlmis-dev/00adbf7d-0e50-473f-b990-aacdcf4bbf53%40googlegroups.com](https://groups.google.com/d/msgid/openlmis-dev/00adbf7d-0e50-473f-b990-aacdcf4bbf53%40googlegroups.com?utm_medium=email&utm_source=footer).

                              For more options, visit [
                                https://groups.google.com/d/optout](https://groups.google.com/d/optout).

                      You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.

                      To unsubscribe from this group and stop receiving emails from it, send an email to
                        openlmis-dev...@googlegroups.com.

                      To post to this group, send email to
                        openl...@googlegroups.com.

                      To view this discussion on the web visit [
                        https://groups.google.com/d/msgid/openlmis-dev/C4756241-5C77-4538-8258-6CD82CEB6C5E%40villagereach.org](https://groups.google.com/d/msgid/openlmis-dev/C4756241-5C77-4538-8258-6CD82CEB6C5E%40villagereach.org?utm_medium=email&utm_source=footer).

                      For more options, visit [
                        https://groups.google.com/d/optout](https://groups.google.com/d/optout).
        **<img src="https://lh3.googleusercontent.com/proxy/Kq7icsK3MEQjYLwBW84HwuYjQ8aFuyyirMOzt_ENZ5BgyyRVaFVgsbO-vnqZPEKtkcm1Gs2mKJSDSi59adej7wSt1KiO3u5QJa2SfrMvGRh8cyONHJScEXiljA=w5000-h5000" height="35" width="145">

            SolDevelo** Sp. z o.o. [LLC] / [
            www.soldevelo.com](http://www.soldevelo.com/)

          Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland

          Phone:                 +48 58 782 45 40 / Fax:                 +48 58 782 45 41

        You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.

        To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev...@googlegroups.com.

        To post to this group, send email to
        ...@googlegroups.com.

        To view this discussion on the web visit [

https://groups.google.com/d/msgid/openlmis-dev/1df1a269-8f06-48be-9686-aeb7a6c96704%40googlegroups.com](https://groups.google.com/d/msgid/openlmis-dev/1df1a269-8f06-48be-9686-aeb7a6c96704%40googlegroups.com?utm_medium=email&utm_source=footer).

        For more options, visit [https://groups.google.com/d/optout](https://groups.google.com/d/optout).
  --

  You received this message because you are subscribed to the Google Groups "OpenLMIS Dev" group.

  To unsubscribe from this group and stop receiving emails from it, send an email to openlmis-dev...@googlegroups.com.

  To post to this group, send email to openlm...@googlegroups.com.

  To view this discussion on the web visit [https://groups.google.com/d/msgid/openlmis-dev/921D23AE-398B-471B-AAFB-9FEC7739592D%40villagereach.org](https://groups.google.com/d/msgid/openlmis-dev/921D23AE-398B-471B-AAFB-9FEC7739592D%40villagereach.org?utm_medium=email&utm_source=footer).

  For more options, visit [https://groups.google.com/d/optout](https://groups.google.com/d/optout).


Sebastian Brudziński

    Software Developer / Team Leader


     sbrud...@soldevelo.com


SolDevelo
Sp. z o.o. [LLC] / www.soldevelo.com
Al. Zwycięstwa 96/98, 81-451, Gdynia, Poland
Phone: +48 58 782 45 40 / Fax: +48 58 782 45 41